[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/15] rust: pl011, qemu_api tests: do not use ClassInitImpl
From: |
Zhao Liu |
Subject: |
Re: [PATCH 04/15] rust: pl011, qemu_api tests: do not use ClassInitImpl |
Date: |
Mon, 24 Feb 2025 23:14:54 +0800 |
On Fri, Feb 21, 2025 at 06:03:31PM +0100, Paolo Bonzini wrote:
> Date: Fri, 21 Feb 2025 18:03:31 +0100
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH 04/15] rust: pl011, qemu_api tests: do not use ClassInitImpl
> X-Mailer: git-send-email 2.48.1
>
> Outside the qemu_api crate, orphan rules make the usage of ClassInitImpl
> unwieldy. Now that it is optional, do not use it.
>
> For PL011Class, this makes it easier to provide a PL011Impl trait similar
> to the ones in the qemu_api crate. The device id consts are moved there.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> rust/hw/char/pl011/src/device.rs | 38 ++++++++++++++++----------------
> rust/qemu-api/tests/tests.rs | 33 ++++++++++-----------------
> 2 files changed, 31 insertions(+), 40 deletions(-)>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
- [PATCH 00/15] rust: prepare for splitting crates, Paolo Bonzini, 2025/02/21
- [PATCH 01/15] rust: add IsA bounds to QOM implementation traits, Paolo Bonzini, 2025/02/21
- [PATCH 03/15] rust: qom: add ObjectImpl::CLASS_INIT, Paolo Bonzini, 2025/02/21
- [PATCH 02/15] rust: add SysBusDeviceImpl, Paolo Bonzini, 2025/02/21
- [PATCH 04/15] rust: pl011, qemu_api tests: do not use ClassInitImpl, Paolo Bonzini, 2025/02/21
- Re: [PATCH 04/15] rust: pl011, qemu_api tests: do not use ClassInitImpl,
Zhao Liu <=
- [PATCH 05/15] rust: qom: get rid of ClassInitImpl, Paolo Bonzini, 2025/02/21
- [PATCH 08/15] rust: timer: wrap QEMUTimer with Opaque<>, Paolo Bonzini, 2025/02/21
- [PATCH 07/15] rust: qemu_api_macros: add Wrapper derive macro, Paolo Bonzini, 2025/02/21
- [PATCH 06/15] rust: cell: add wrapper for FFI types, Paolo Bonzini, 2025/02/21
- [PATCH 09/15] rust: irq: wrap IRQState with Opaque<>, Paolo Bonzini, 2025/02/21