[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retadd
From: |
David Hildenbrand |
Subject: |
Re: [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions |
Date: |
Wed, 29 Nov 2017 17:05:07 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 29.11.2017 16:57, Cornelia Huck wrote:
> On Wed, 29 Nov 2017 16:45:21 +0100
> David Hildenbrand <address@hidden> wrote:
>
>> On 29.11.2017 16:39, Cornelia Huck wrote:
>>> On Wed, 29 Nov 2017 16:38:03 +0100
>>> David Hildenbrand <address@hidden> wrote:
>>>
>>>> On 29.11.2017 16:35, Cornelia Huck wrote:
>>>>> On Wed, 29 Nov 2017 16:14:40 +0100
>>>>> David Hildenbrand <address@hidden> wrote:
>>>>>
>>>>>> On 29.11.2017 16:13, Cornelia Huck wrote:
>>>>>>> On Tue, 28 Nov 2017 21:33:14 +0100
>>>>>>> David Hildenbrand <address@hidden> wrote:
>>>>>>>
>>>>>>>> TCG needs the retaddr when injecting an interrupt. Let's just pass it
>>>>>>>> along and use 0 for KVM. The value will be completely ignored for KVM.
>>>>>>>>
>>>>>>>
>>>>>>> Can we get a #define for that? Just to make it clear at a glance that
>>>>>>> we're passing an ignored value and not some magic thing.
>>>>>>
>>>>>> If you can come up with a good name, I can't :)
>>>>>
>>>>> KVM_FAKE_RA
>>>>> KVM_RA_UNUSED
>>>>> KVM_RA_IGNORED
>>>>>
>>>>> ?
>>>>>
>>>>
>>>> KVM_RA ? (to keep lines short?)
>>>>
>>>
>>> That sounds too much like a magic value IMO (and not something that is
>>> ignored).
>>>
>>
>> Passing 0 will actually also ignore it for TCG. So it is actually a
>> magic value :) (just that more gets ignore din case of KVM ...)
>>
>> RA_NONE ?
>>
>>
>
> RA_IGNORED?
>
jap, will use that.
--
Thanks,
David / dhildenb
- Re: [qemu-s390x] [PATCH v1 for-2.12 07/15] s390x: handle exceptions during s390_cpu_virt_mem_rw() correctly (TCG), (continued)
- [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions, David Hildenbrand, 2017/11/28
- Re: [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions, Cornelia Huck, 2017/11/29
- Re: [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions, David Hildenbrand, 2017/11/29
- Re: [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions, Cornelia Huck, 2017/11/29
- Re: [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions, David Hildenbrand, 2017/11/29
- Re: [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions, Cornelia Huck, 2017/11/29
- Re: [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions, David Hildenbrand, 2017/11/29
- Re: [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions, Cornelia Huck, 2017/11/29
- Re: [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions,
David Hildenbrand <=
Re: [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions, Richard Henderson, 2017/11/29
[qemu-s390x] [PATCH v1 for-2.12 05/15] s390x/pci: pass the retaddr to all PCI instructions, David Hildenbrand, 2017/11/28
[qemu-s390x] [PATCH v1 for-2.12 08/15] s390x/tcg: io instructions don't need potential_page_fault(), David Hildenbrand, 2017/11/28
[qemu-s390x] [PATCH v1 for-2.12 09/15] s390x/tcg: use program_interrupt_ra() in SCLP Service Call, David Hildenbrand, 2017/11/28
[qemu-s390x] [PATCH v1 for-2.12 10/15] s390x/tcg: use program_interrupt_ra() in DIAG, David Hildenbrand, 2017/11/28