[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [Qemu-devel] [PATCH 2/8] error: Remove NULL checks on e
From: |
Markus Armbruster |
Subject: |
Re: [qemu-s390x] [Qemu-devel] [PATCH 2/8] error: Remove NULL checks on error_propagate() calls |
Date: |
Thu, 05 Jul 2018 07:38:57 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Philippe Mathieu-Daudé <address@hidden> writes:
> Patch created mechanically by rerunning:
>
> $ spatch --sp-file scripts/coccinelle/error_propagate_null.cocci \
> --macro-file scripts/cocci-macro-file.h \
> --dir . --in-place
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/s390x/virtio-ccw.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
> index b92a85d0b0..7ddb378d52 100644
> --- a/hw/s390x/virtio-ccw.c
> +++ b/hw/s390x/virtio-ccw.c
> @@ -1836,11 +1836,9 @@ static void vhost_vsock_ccw_realize(VirtioCcwDevice
> *ccw_dev, Error **errp)
> {
> VHostVSockCCWState *dev = VHOST_VSOCK_CCW(ccw_dev);
> DeviceState *vdev = DEVICE(&dev->vdev);
> - Error *err = NULL;
>
> qdev_set_parent_bus(vdev, BUS(&ccw_dev->bus));
> - object_property_set_bool(OBJECT(vdev), true, "realized", &err);
> - error_propagate(errp, err);
> + object_property_set_bool(OBJECT(vdev), true, "realized", errp);
> }
>
> static void vhost_vsock_ccw_class_init(ObjectClass *klass, void *data)
Reviewed-by: Markus Armbruster <address@hidden>