Re: [qemu-s390x] [RFC 02/15] s390-bios: decouple cio setup from virtio

[Cornelia Huck]

On Thu,  5 Jul 2018 13:25:30 -0400
"Jason J. Herne" <address@hidden> wrote:

> From: "Jason J. Herne" <address@hidden>
> 
> Move channel i/o setup code out to a separate function. This decouples cio
> setup from the virtio code path and allows us to make use of it for booting
> dasd devices.
> 
> Signed-off-by: Jason J. Herne <address@hidden>
> Acked-by: Halil Pasic <address@hidden>
> Reviewed-by: Collin Walling <address@hidden>
> Signed-off-by: Jason J. Herne <address@hidden>
> ---
>  pc-bios/s390-ccw/main.c | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)
> 
> diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c
> index 544851d..63117d1 100644
> --- a/pc-bios/s390-ccw/main.c
> +++ b/pc-bios/s390-ccw/main.c
> @@ -99,6 +99,18 @@ static void menu_setup(void)
>      }
>  }
>  
> +/*
> + * Initialize the channel I/O subsystem so we can talk to our ipl/boot 
> device.
> + */
> +static void cio_setup(void)

<bikeshed>Call this css_setup?</bikeshed>

> +{
> +    /*
> +     * Unconditionally enable mss support. In every sane configuration this
> +     * will succeed; and even if it doesn't, stsch_err() can handle it.
> +     */
> +    enable_mss_facility();
> +}
> +
>  static void virtio_setup(void)
>  {
>      Schib schib;