Re: [qemu-s390x] [PATCH 2/2] s390x/kvm: add etoken facility

[Cornelia Huck]

On Tue, 31 Jul 2018 11:04:48 +0200
Christian Borntraeger <address@hidden> wrote:

> Provide the etoken facility. We need to handle cpu model, migration and
> clear reset.
> 
> Signed-off-by: Christian Borntraeger <address@hidden>
> Acked-by: Janosch Frank <address@hidden>
> ---
>  target/s390x/cpu.h              |  3 +++
>  target/s390x/cpu_features.c     |  3 ++-
>  target/s390x/cpu_features_def.h |  3 ++-
>  target/s390x/gen-features.c     |  3 ++-
>  target/s390x/kvm.c              | 11 +++++++++++
>  target/s390x/machine.c          | 20 +++++++++++++++++++-
>  6 files changed, 39 insertions(+), 4 deletions(-)

> @@ -106,6 +106,7 @@ static const S390FeatDef s390_features[] = {
>      FEAT_INIT("irbm", S390_FEAT_TYPE_STFL, 145, 
> "Insert-reference-bits-multiple facility"),
>      FEAT_INIT("msa8-base", S390_FEAT_TYPE_STFL, 146, 
> "Message-security-assist-extension-8 facility (excluding subfunctions)"),
>      FEAT_INIT("cmmnt", S390_FEAT_TYPE_STFL, 147, "CMM: ESSA-enhancement (no 
> translate) facility"),
> +    FEAT_INIT("etoken", S390_FEAT_TYPE_STFL, 156, "etoken facility"),

Don't facilities usually start with a capital letter?

>  
>      /* SCLP SCCB Byte 80 - 98  (bit numbers relative to byte-80) */
>      FEAT_INIT("gsls", S390_FEAT_TYPE_SCLP_CONF_CHAR, 40, "SIE: 
> Guest-storage-limit-suppression facility"),