Re: [qemu-s390x] [PATCH v4 1/3] target/s390x: use regular spaces in translate.c

[David Hildenbrand]

On 22.08.2018 16:40, Pavel Zbitskiy wrote:
> In a few places translate.c contains non-breaking spaces (0xc2 0xa0)
> instead of regular ones (0x20):
> 
>   7c 7c c2 a0 63 63
>   7c 7c 20    63 63
>   |  |        c  c
> 
> This confuses some text editors.
> 
> Signed-off-by: Pavel Zbitskiy <address@hidden>
> ---
>  target/s390x/translate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/s390x/translate.c b/target/s390x/translate.c
> index 40e12ca2c4..7363aabf3a 100644
> --- a/target/s390x/translate.c
> +++ b/target/s390x/translate.c
> @@ -842,7 +842,7 @@ static void disas_jcc(DisasContext *s, DisasCompare *c, 
> uint32_t mask)
>              cond = TCG_COND_NE;
>              c->u.s32.b = tcg_const_i32(1);
>              break;
> -        case 0x8 | 0x2: /* cc == 0 || cc == 2 => (cc & 1) == 0 */
> +        case 0x8 | 0x2: /* cc == 0 || cc == 2 => (cc & 1) == 0 */
>              cond = TCG_COND_EQ;
>              c->g1 = false;
>              c->u.s32.a = tcg_temp_new_i32();
> @@ -861,7 +861,7 @@ static void disas_jcc(DisasContext *s, DisasCompare *c, 
> uint32_t mask)
>              cond = TCG_COND_NE;
>              c->u.s32.b = tcg_const_i32(0);
>              break;
> -        case 0x4 | 0x1: /* cc == 1 || cc == 3 => (cc & 1) != 0 */
> +        case 0x4 | 0x1: /* cc == 1 || cc == 3 => (cc & 1) != 0 */
>              cond = TCG_COND_NE;
>              c->g1 = false;
>              c->u.s32.a = tcg_temp_new_i32();
> 

(can't spot a difference in my mail editor ;) )

Reviewed-by: David Hildenbrand <address@hidden>

-- 

Thanks,

David / dhildenb