Re: [qemu-s390x] [PATCH] tests/migration: Enable the migration test on s390x, too

[Thomas Huth]

On 2018-08-23 16:54, Cornelia Huck wrote:
> On Thu, 23 Aug 2018 14:25:20 +0200
> Thomas Huth <address@hidden> wrote:
> 
>> We can re-use the s390-ccw bios code to implement a small firmware
>> for a s390x guest which prints out the "A" and "B" characters and
>> modifies the memory, as required for the migration test.
>>
>> Signed-off-by: Thomas Huth <address@hidden>
>> ---
>>  tests/Makefile.include               |   1 +
>>  tests/migration-test.c               |  23 ++
>>  tests/migration/s390x-a-b-rebuild.sh |  42 ++++
>>  tests/migration/s390x-a-b.c          |  35 +++
>>  tests/migration/s390x-a-b.h          | 427 
>> +++++++++++++++++++++++++++++++++++
>>  5 files changed, 528 insertions(+)
>>  create mode 100755 tests/migration/s390x-a-b-rebuild.sh
>>  create mode 100644 tests/migration/s390x-a-b.c
>>  create mode 100644 tests/migration/s390x-a-b.h
> 
> Hm, I wanted to comment that those new files should be added to the
> MAINTAINERS file pattern (here as well :), but tests/migration does not
> seem to have an entry in MAINTAINERS yet...

Yeah, but that's a pre-existing problem... care to send a patch?

>> diff --git a/tests/migration/s390x-a-b.h b/tests/migration/s390x-a-b.h
>> new file mode 100644
>> index 0000000..eb1bab4
>> --- /dev/null
>> +++ b/tests/migration/s390x-a-b.h
>> @@ -0,0 +1,427 @@
>> +/*
>> + * This file is automatically generated from tests/migration/s390x-a-b.c, 
>> edit
>> + * that and then run tests/migration/s390x-a-b-rebuild.sh to update, and 
>> then
>> + * remember to send both in your patch submission.
>> + */
> 
> And here I assumed that this file would be lovingly hand-crafted :)

I was just about to warm up my hardly existing assembler foo, when I
noticed that it is easier to write C here ;-)

> Acked-by: Cornelia Huck <address@hidden>

Thanks!

 Thomas