[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v2 2/6] s390x/vfio: ap: Use the APdevice as a ch
|
From: |
Cornelia Huck |
|
Subject: |
Re: [qemu-s390x] [PATCH v2 2/6] s390x/vfio: ap: Use the APdevice as a child of the APBus |
|
Date: |
Thu, 29 Nov 2018 16:11:15 +0100 |
On Thu, 29 Nov 2018 10:02:24 -0500
Tony Krowiak <address@hidden> wrote:
> On 11/29/18 6:45 AM, Cornelia Huck wrote:
> > On Thu, 22 Nov 2018 17:35:51 +0100
> > Pierre Morel <address@hidden> wrote:
> >> diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
> >> index 65de952..94e5a1a 100644
> >> --- a/hw/vfio/ap.c
> >> +++ b/hw/vfio/ap.c
> >> @@ -35,9 +35,6 @@ typedef struct VFIOAPDevice {
> >> VFIODevice vdev;
> >> } VFIOAPDevice;
> >>
> >> -#define VFIO_AP_DEVICE(obj) \
> >> - OBJECT_CHECK(VFIOAPDevice, (obj), VFIO_AP_DEVICE_TYPE)
> >
> > Hm?
>
> I received a comment from Thomas Huth in Message ID
> <address@hidden>
> that DO_UPCAST should be avoided in new code. This macro
> should probably be restored and an AP_DEVICE() macro added.
Yes, that makes sense.
[qemu-s390x] [PATCH v2 1/6] s390x/vfio: ap: Finding the AP bridge, Pierre Morel, 2018/11/22
[qemu-s390x] [PATCH v2 3/6] s390x/vfio: ap: Linux uapi VFIO place holder, Pierre Morel, 2018/11/22