[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH] hw/s390x: Fix the function arguments in the pci
|
From: |
Cornelia Huck |
|
Subject: |
Re: [qemu-s390x] [PATCH] hw/s390x: Fix the function arguments in the pci stub file |
|
Date: |
Thu, 31 Jan 2019 18:56:21 +0100 |
On Thu, 31 Jan 2019 18:47:08 +0100
Thomas Huth <address@hidden> wrote:
> The arguments of the stub functions to not match the real implementation
s/to/do/
> (and the prototypes in the header) anymore, so if you try to compile s390x
> without CONFIG_PCI, the build currently fails.
>
Fixes: 468a93898a97 ("s390x/pci: pass the retaddr to all PCI instructions")
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> hw/s390x/s390-pci-stub.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
This file seems to be in danger of bitrot. Do you think it'll be easier
to test rarely used configs like that after we switch to Kconfig?