Re: [qemu-s390x] [PATCH v2 5/6] tests/device-plug: Add CPU core unplug request test for spapr

[Thomas Huth]

On 15/02/2019 14.30, David Hildenbrand wrote:
> We can easily test this, just like PCI.

... maybe add a sentence why this is only done for spapr, and not for
s390x and x86 ?

> Signed-off-by: David Hildenbrand <address@hidden>
> ---
>  tests/device-plug-test.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/tests/device-plug-test.c b/tests/device-plug-test.c
> index 6f7255552a..ec6cb5de7b 100644
> --- a/tests/device-plug-test.c
> +++ b/tests/device-plug-test.c
> @@ -101,6 +101,21 @@ static void test_ccw_unplug(void)
>      qtest_quit(qtest);
>  }
>  
> +static void test_spapr_cpu_unplug_request(void)
> +{
> +    QTestState *qtest;
> +
> +    qtest = qtest_initf("-cpu power9_v2.0 -smp 1,maxcpus=2 "
> +                        "-device 
> power9_v2.0-spapr-cpu-core,core-id=1,id=dev0");
> +
> +    /* similar to test_pci_unplug_request */
> +    device_del_request(qtest, "dev0");
> +    system_reset(qtest);
> +    wait_device_deleted_event(qtest, "dev0");
> +
> +    qtest_quit(qtest);
> +}

My initial thought was: This should go into tests/cpu-plug-test.c
instead ... but since you need the functions that you defined here,
looks like this is the better place here...

>  int main(int argc, char **argv)
>  {
>      const char *arch = qtest_get_arch();
> @@ -120,5 +135,10 @@ int main(int argc, char **argv)
>                         test_ccw_unplug);
>      }
>  
> +    if (!strcmp(arch, "ppc64")) {
> +        qtest_add_func("/device-plug/spapr_cpu_unplug_request",

spapr-cpu-unplug-request ?

> +                       test_spapr_cpu_unplug_request);
> +    }
> +
>      return g_test_run();
>  }

Reviewed-by: Thomas Huth <address@hidden>