[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PATCH v3 21/25] s390x/sclp: Use size_t in process_mdb()
From: |
Philippe Mathieu-Daudé |
Subject: |
[qemu-s390x] [PATCH v3 21/25] s390x/sclp: Use size_t in process_mdb() |
Date: |
Wed, 20 Feb 2019 02:02:28 +0100 |
Since it is unlikely we have sizeof(mdbo->mto.message) < 0,
we can convert this variable to an unsigned type.
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/char/sclpconsole-lm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/char/sclpconsole-lm.c b/hw/char/sclpconsole-lm.c
index 49543e2c83..48c76d863e 100644
--- a/hw/char/sclpconsole-lm.c
+++ b/hw/char/sclpconsole-lm.c
@@ -208,7 +208,7 @@ static int write_console_data(SCLPEvent *event, const
uint8_t *buf, int len)
static int process_mdb(SCLPEvent *event, MDBO *mdbo)
{
int rc;
- int len;
+ uint16_t len;
uint8_t buffer[SIZE_BUFFER];
const size_t hlen = sizeof(mdbo->length)
+ sizeof(mdbo->type)
@@ -217,6 +217,7 @@ static int process_mdb(SCLPEvent *event, MDBO *mdbo)
+ sizeof(mdbo->mto._reserved);
len = be16_to_cpu(mdbo->length);
+ assert(len >= hlen);
len -= hlen;
assert(len <= SIZE_BUFFER);
--
2.20.1
- [qemu-s390x] [PATCH v3 17/25] net/filter-mirror: Use size_t, (continued)
- [qemu-s390x] [PATCH v3 16/25] tpm: Use size_t to hold sizes, Philippe Mathieu-Daudé, 2019/02/19
- [qemu-s390x] [PATCH v3 18/25] s390x/3270: Let insert_IAC_escape_char() use size_t, Philippe Mathieu-Daudé, 2019/02/19
- [qemu-s390x] [PATCH v3 21/25] s390x/sclp: Use size_t in process_mdb(),
Philippe Mathieu-Daudé <=
- [qemu-s390x] [PATCH v3 22/25] s390x/sclp: Let write_console_data() take a size_t, Philippe Mathieu-Daudé, 2019/02/19
- [qemu-s390x] [PATCH v3 24/25] chardev: Let qemu_chr_fe_write[_all] use size_t type argument, Philippe Mathieu-Daudé, 2019/02/19
- Re: [qemu-s390x] [PATCH v3 00/25] chardev: Convert qemu_chr_write() to take a size_t argument, Marc-André Lureau, 2019/02/20