Re: [qemu-s390x] [Qemu-devel] [PATCH v1 5/7] s390x/tcg: Factor out gen_addi_and_wrap_i64() from get_address()

[David Hildenbrand]

On 25.02.19 16:53, Richard Henderson wrote:
> On 2/25/19 3:55 AM, David Hildenbrand wrote:
>> Also properly wrap in 24bit mode. While at it, convert the comment (and
>> drop the comment about fundamental TCG optimizations).
>>
>> Signed-off-by: David Hildenbrand <address@hidden>
>> ---
>>  target/s390x/translate.c | 41 +++++++++++++++++++++++++---------------
>>  1 file changed, 26 insertions(+), 15 deletions(-)
> 
> Reviewed-by: Richard Henderson <address@hidden>
> 
>> +static inline void gen_addi_and_wrap_i64(DisasContext *s, TCGv_i64 dst,
>> +                                         TCGv_i64 src, int64_t imm)
> 
> I would drop the inline and let the compiler choose.
> I'm using very few explicit inline markers these days...

Makes sense, the compiler usually knows better. Thanks!

> 
> 
> r~
> 


-- 

Thanks,

David / dhildenb