Re: [qemu-s390x] [PATCH v3 01/15] s390x/tcg: Fix TEST DATA CLASS instructions

[David Hildenbrand]

On 18.02.19 13:26, David Hildenbrand wrote:
> Let's detect normal and denormal ("subnormal") numbers reliably. Also
> test for quiet NaN's. As only one class is possible, test common cases
> first.
> 
> While at it, use a better check to test for the mask bits in the data
> class mask. The data class mask has 12 bits, whereby bit 0 is the
> leftmost bit and bit 11 the rightmost bit. In the PoP an easy to read
> table with the numbers is provided for the VECTOR FP TEST DATA CLASS
> IMMEDIATE instruction, the table for TEST DATA CLASS is more confusing
> as it is based on 64 bit values.
> 
> Factor the checks out into separate functions, as they will also be
> needed for floating point vector instructions. We can use a makro to
> generate the functions.
> 
> Signed-off-by: David Hildenbrand <address@hidden>

Seems like I forgot

Reviewed-by: Richard Henderson <address@hidden>

from Richard (sorry!)

-- 

Thanks,

David / dhildenb