Re: [qemu-s390x] [Qemu-devel] [PATCH v1 21/33] s390x/tcg: Implement VECTOR PACK (LOGICAL) SATURATE

[Richard Henderson]

On 2/26/19 3:39 AM, David Hildenbrand wrote:
> We'll implement both via gvec ool helpers. As these can't return
> values, we'll return the CC via env->cc_op. Generate different C
> functions for the different cases using makros.
> 
> In the future we might want to do a translation like VECTOR PACK or
> use separate handlers in case no CC update is needed. As linux does
> not seem to use the function right now, no need to tune for performance.

Fair enough.

> 
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
>  target/s390x/helper.h           |  6 +++
>  target/s390x/insn-data.def      |  4 ++
>  target/s390x/translate_vx.inc.c | 37 ++++++++++++++++
>  target/s390x/vec_helper.c       | 75 +++++++++++++++++++++++++++++++++
>  4 files changed, 122 insertions(+)

Reviewed-by: Richard Henderson <address@hidden>


r~