[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PULL 01/10] tests: Remove (mostly) useless architecture ch
From: |
Laurent Vivier |
Subject: |
[qemu-s390x] [PULL 01/10] tests: Remove (mostly) useless architecture checks |
Date: |
Wed, 6 Mar 2019 12:07:02 +0100 |
From: Thomas Huth <address@hidden>
These checks at the beginning of some of the tests are mostly useless:
We only run the tests on x86 anyway, and g_test_message() does not
print anything unless you call g_test_init() first.
Signed-off-by: Thomas Huth <address@hidden>
Acked-by: John Snow <address@hidden>
Acked-by: Corey Minyard <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
tests/fdc-test.c | 7 -------
tests/ide-test.c | 7 -------
tests/ipmi-bt-test.c | 7 -------
tests/ipmi-kcs-test.c | 7 -------
4 files changed, 28 deletions(-)
diff --git a/tests/fdc-test.c b/tests/fdc-test.c
index 88f1abfa10e2..31cd3295c102 100644
--- a/tests/fdc-test.c
+++ b/tests/fdc-test.c
@@ -548,16 +548,9 @@ static void fuzz_registers(void)
int main(int argc, char **argv)
{
- const char *arch = qtest_get_arch();
int fd;
int ret;
- /* Check architecture */
- if (strcmp(arch, "i386") && strcmp(arch, "x86_64")) {
- g_test_message("Skipping test for non-x86\n");
- return 0;
- }
-
/* Create a temporary raw image */
fd = mkstemp(test_image);
g_assert(fd >= 0);
diff --git a/tests/ide-test.c b/tests/ide-test.c
index f0280e636b5d..300d64e77ddf 100644
--- a/tests/ide-test.c
+++ b/tests/ide-test.c
@@ -1009,16 +1009,9 @@ static void test_cdrom_dma(void)
int main(int argc, char **argv)
{
- const char *arch = qtest_get_arch();
int fd;
int ret;
- /* Check architecture */
- if (strcmp(arch, "i386") && strcmp(arch, "x86_64")) {
- g_test_message("Skipping test for non-x86\n");
- return 0;
- }
-
/* Create temporary blkdebug instructions */
fd = mkstemp(debug_path);
g_assert(fd >= 0);
diff --git a/tests/ipmi-bt-test.c b/tests/ipmi-bt-test.c
index f4a81b526505..fc4c83b5db7c 100644
--- a/tests/ipmi-bt-test.c
+++ b/tests/ipmi-bt-test.c
@@ -400,15 +400,8 @@ static void open_socket(void)
int main(int argc, char **argv)
{
- const char *arch = qtest_get_arch();
int ret;
- /* Check architecture */
- if (strcmp(arch, "i386") && strcmp(arch, "x86_64")) {
- g_test_message("Skipping test for non-x86\n");
- return 0;
- }
-
open_socket();
/* Run the tests */
diff --git a/tests/ipmi-kcs-test.c b/tests/ipmi-kcs-test.c
index 178ffc179734..a2354c10c7fe 100644
--- a/tests/ipmi-kcs-test.c
+++ b/tests/ipmi-kcs-test.c
@@ -263,16 +263,9 @@ static void test_enable_irq(void)
int main(int argc, char **argv)
{
- const char *arch = qtest_get_arch();
char *cmdline;
int ret;
- /* Check architecture */
- if (strcmp(arch, "i386") && strcmp(arch, "x86_64")) {
- g_test_message("Skipping test for non-x86\n");
- return 0;
- }
-
/* Run the tests */
g_test_init(&argc, &argv, NULL);
--
2.20.1
- [qemu-s390x] [PULL 00/10] Trivial branch patches, Laurent Vivier, 2019/03/06
- [qemu-s390x] [PULL 05/10] block/pflash_cfi02: Fix memory leak and potential use-after-free, Laurent Vivier, 2019/03/06
- [qemu-s390x] [PULL 07/10] bswap: Fix accessors syntax in comment, Laurent Vivier, 2019/03/06
- [qemu-s390x] [PULL 04/10] hw/acpi: remove unnecessary variable acpi_table_builtin, Laurent Vivier, 2019/03/06
- [qemu-s390x] [PULL 03/10] hw/acpi: remove unused function acpi_table_add_builtin(), Laurent Vivier, 2019/03/06
- [qemu-s390x] [PULL 02/10] hw/i386/pc.c: remove unused function pc_acpi_init(), Laurent Vivier, 2019/03/06
- [qemu-s390x] [PULL 10/10] thunk: fix of malloc to g_new, Laurent Vivier, 2019/03/06
- [qemu-s390x] [PULL 08/10] build: Correct explanation of unnest-vars example, Laurent Vivier, 2019/03/06
- [qemu-s390x] [PULL 09/10] hostmem-file: simplify ifdef-s in file_backend_memory_alloc(), Laurent Vivier, 2019/03/06
- [qemu-s390x] [PULL 06/10] doc: fix typos for documents in tree, Laurent Vivier, 2019/03/06
- [qemu-s390x] [PULL 01/10] tests: Remove (mostly) useless architecture checks,
Laurent Vivier <=
- Re: [qemu-s390x] [Qemu-devel] [PULL 00/10] Trivial branch patches, Peter Maydell, 2019/03/06