Re: [qemu-s390x] [PATCH v5 16/20] Boot Linux Console Test for ppc64 + pseries: use power8 CPU model

[David Gibson]

On Tue, Mar 12, 2019 at 01:18:20PM -0400, Cleber Rosa wrote:
> Because of the changes in da874d90a, the Fedora 29 kernel doesn't
> boot with the modified version of the Power9 CPU.  Let's set the
> power8 CPU instead.
> 
> Signed-off-by: Cleber Rosa <address@hidden>
> CC: Cédric Le Goater <address@hidden>
> CC: David Gibson <address@hidden>

Nack.

Fedora *should* boot with Power9 on a pseries machine type, which I
think is what you're using here.  We need to fix that bug, rather than
cover it up.

> ---
>  tests/acceptance/boot_linux_console.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/acceptance/boot_linux_console.py 
> b/tests/acceptance/boot_linux_console.py
> index edc7722abe..50ced6549b 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -149,7 +149,8 @@ class BootLinuxConsole(Test):
>          self.vm.set_console()
>          kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 
> 'console=hvc0'
>          self.vm.add_args('-kernel', kernel_path,
> -                         '-append', kernel_command_line)
> +                         '-append', kernel_command_line,
> +                         '-cpu', 'power8')
>          self.vm.launch()
>          console_pattern = 'Kernel command line: %s' % kernel_command_line
>          self.wait_for_console_pattern(console_pattern)

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature