Re: [qemu-s390x] [PATCH v2 2/2] exec: Introduce qemu_getmaxrampagesize() and rename qemu_getrampagesize()

[David Hildenbrand]

>> ---
>>  exec.c                     | 39 ++++++++++++++++++++++++++++++++++----
>>  hw/ppc/spapr_caps.c        |  4 ++--
>>  hw/s390x/s390-virtio-ccw.c |  2 +-
>>  hw/vfio/spapr.c            |  2 +-
>>  target/ppc/kvm.c           |  2 +-
>>  5 files changed, 40 insertions(+), 9 deletions(-)
>>
>> diff --git a/exec.c b/exec.c
>> index 6ab62f4eee..cf74f5f284 100644
>> --- a/exec.c
>> +++ b/exec.c
>> @@ -1687,7 +1687,7 @@ void ram_block_dump(Monitor *mon)
>>   * when we actually open and map them.  Iterate over the file
>>   * descriptors instead, and use qemu_fd_getpagesize().
>>   */
>> -static int find_max_supported_pagesize(Object *obj, void *opaque)
>> +static int find_min_pagesize(Object *obj, void *opaque)
> 
> Maybe find_min_host_pagesize() to clarify exactly what we're finding.

Hm, that sounds like a function that finds the minimum host page size in
general, which could be misleading.

find_min_backend_pagesize it is :)

> 
>>  {
>>      long *hpsize_min = opaque;
>>  
>> @@ -1703,7 +1703,23 @@ static int find_max_supported_pagesize(Object *obj, 
>> void *opaque)
>>      return 0;
>>  }
>>  
>> -long qemu_getrampagesize(void)
>> +static int find_max_pagesize(Object *obj, void *opaque)
>> +{
>> +    long *hpsize_max = opaque;
>> +
>> +    if (object_dynamic_cast(obj, TYPE_MEMORY_BACKEND)) {
>> +        HostMemoryBackend *backend = MEMORY_BACKEND(obj);
>> +        long hpsize = host_memory_backend_pagesize(backend);
>> +
>> +        if (host_memory_backend_is_mapped(backend) && (hpsize > 
>> *hpsize_max)) {
>> +            *hpsize_max = hpsize;
>> +        }
>> +    }
>> +
>> +    return 0;
>> +}
>> +
>> +long qemu_getminrampagesize(void)
> 
> s/getminrampagesize/minrampagesize/ for brevity.
> 
> The "get" doesn't really add anything useful.

Had the same thing in mind!

Thanks David!

-- 

Thanks,

David / dhildenb