Re: [qemu-s390x] [PATCH v3 3/5] configure: qemu-ga is only needed with softmmu targets

[Thomas Huth]

On 01/04/2019 16.12, Laurent Vivier wrote:
> Remove it from the list of tools if --disable-system
> and --disable-tools are used as we don't need it for
> linux-user targets.
> 
> Suggested-by: Paolo Bonzini <address@hidden>
> [lv: I also disable it with disable-tools, not only with disable-system]
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
>  configure | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 1c563a70276a..b627efede6cf 100755
> --- a/configure
> +++ b/configure
> @@ -6083,7 +6083,9 @@ fi
>  # Probe for guest agent support/options
>  
>  if [ "$guest_agent" != "no" ]; then
> -  if [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" -o 
> "$mingw32" = "yes" ] ; then
> +  if [ "$softmmu" = no -a "$want_tools" = no ] ; then
> +      guest_agent=no
> +  elif [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" -o 
> "$mingw32" = "yes" ] ; then
>        tools="qemu-ga $tools"
>        guest_agent=yes
>    elif [ "$guest_agent" != yes ]; then
> 

Reviewed-by: Thomas Huth <address@hidden>