Re: [qemu-s390x] [PATCH v2 0/2] s390x/kvm: Properly detect page size of initial memory

[Cornelia Huck]

On Thu, 28 Mar 2019 12:34:56 +0100
David Hildenbrand <address@hidden> wrote:

> This is based on the patch
>     [PATCH for-4.0?] exec: Only count mapped memory backends for
>     qemu_getrampagesize()
> 
> While the detection on s390x of the maximum ram pagesize works by pure luck,
> we should try to do better. Especially, once "-mem-path" is replaced
> by memory backends, the current approach will break.
> 
> Configure the maximum page size after configuring initital memory. Provide
> a function to detect the maximum ram pagesize
> 
> I think this can be deferred to 4.1 as I don't think anything is actually
> broken right now.

I agree.

> 
> v1 -> v2:
> - Add a better comment describing that only initial memory is considered
> - Add "exec: Introduce qemu_getmaxrampagesize() and rename
>   qemu_getrampagesize()"
> 
> David Hildenbrand (2):
>   s390x/kvm: Configure page size after memory has actually been
>     initialized

I can queue that one to s390-next (not s390-fixes)... has this been tested?

>   exec: Introduce qemu_getmaxrampagesize() and rename
>     qemu_getrampagesize()
> 
>  exec.c                     | 39 ++++++++++++++++++++++++++++++++++----
>  hw/ppc/spapr_caps.c        |  4 ++--
>  hw/s390x/s390-virtio-ccw.c | 12 ++++++++++++
>  hw/vfio/spapr.c            |  2 +-
>  target/ppc/kvm.c           |  2 +-
>  target/s390x/cpu.c         |  7 +++++++
>  target/s390x/cpu.h         |  1 +
>  target/s390x/kvm-stub.c    |  4 ++++
>  target/s390x/kvm.c         | 35 ++++++++++++++--------------------
>  target/s390x/kvm_s390x.h   |  1 +
>  10 files changed, 78 insertions(+), 29 deletions(-)
>