|
From: | Farhan Ali |
Subject: | Re: [qemu-s390x] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs |
Date: | Mon, 8 Apr 2019 13:02:12 -0400 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 03/01/2019 04:38 AM, Cornelia Huck wrote:
When we get a solicited interrupt, the start function may have been cleared by a csch, but we still have a channel program structure allocated. Make it safe to call the cp accessors in any case, so we can call them unconditionally. While at it, also make sure that functions called from other parts of the code return gracefully if the channel program structure has not been initialized (even though that is a bug in the caller). Reviewed-by: Eric Farman<address@hidden> Signed-off-by: Cornelia Huck<address@hidden> ---
Hi Connie,My series of fixes for vfio-ccw depends on this patch as I would like to call cp_free unconditionally :) (I had developed my code on top of your patches).
Could we pick this patch up as well when/if you pick up my patch series? I am in the process of sending out a v2.
Regarding this patch we could merge it as a stand alone patch, separate from this series. And also the patch LGTM
Reviewed-by: Farhan Ali <address@hidden> Thanks Farhan
[Prev in Thread] | Current Thread | [Next in Thread] |