Re: [qemu-s390x] [Qemu-devel] [PATCH v1 11/41] s390x/tcg: Implement VECTOR COMPARE *

[Richard Henderson]

On 4/11/19 12:08 AM, David Hildenbrand wrote:
> To carry out the comparison, we can reuse the existing gvec comparison
> function. In case the CC is to be computed, save the result vector
> and compute the CC lazily. The result is a vector consisting of all 1's
> for elements that matched and 0's for elements that didn't match.
> 
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
>  target/s390x/cc_helper.c        | 17 +++++++++++++++++
>  target/s390x/helper.c           |  1 +
>  target/s390x/insn-data.def      |  6 ++++++
>  target/s390x/internal.h         |  1 +
>  target/s390x/translate.c        |  1 +
>  target/s390x/translate_vx.inc.c | 28 ++++++++++++++++++++++++++++
>  6 files changed, 54 insertions(+)

Reviewed-by: Richard Henderson <address@hidden>


r~