Re: [qemu-s390x] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

[David Hildenbrand]

On 24.05.19 20:28, Christian Borntraeger wrote:
> 
> 
> On 24.05.19 20:04, David Hildenbrand wrote:
>> On 24.05.19 19:54, Philippe Mathieu-Daudé wrote:
>>> Hi Christian,
>>>
>>> I'm having hard time to understand why the S390_IPL object calls
>>> qemu_register_reset(qdev_reset_all_fn) in its realize() method, while
>>> being QOM'ified (it has a reset method).
>>>
>>> It doesn't seem to have a qdev children added explicitly to it.
>>> I see it is used as a singleton, what else am I missing?
>>>
>>> Thanks,
>>>
>>> Phil.
>>>
>>
>> Looks like I added it back then (~4 years ago) when converting it into a
>> TYPE_DEVICE.
>>
>> I could imagine that - back then - this was needed because only
>> TYPE_SYS_BUS_DEVICE would recursively get reset.
> 
> Yes, back then singleton devices were not recursively resetted. Has that 
> changed?

Hacking that call out, I don't see it getting called anymore. So it is
still required. The question is if it can be reworked.

-- 

Thanks,

David / dhildenb