Re: [qemu-s390x] [Qemu-devel] [PATCH v2 5/5] s390x/tcg: Implement VECTOR STRING RANGE COMPARE

[Richard Henderson]

On 5/24/19 4:33 AM, David Hildenbrand wrote:
> Unfortunately, there is no easy way to avoid looping over all elements
> in v2. Provide specialized variants for !cc,!rt/!cc,rt/cc,!rt/cc,rt and
> all element types. Especially for different values of rt, the compiler
> might be able to optimize the code a lot.
> 
> Add s390_vec_write_element().
> 
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
>  target/s390x/helper.h            |  12 +++
>  target/s390x/insn-data.def       |   2 +
>  target/s390x/translate_vx.inc.c  |  59 +++++++++++++
>  target/s390x/vec.h               |  21 +++++
>  target/s390x/vec_string_helper.c | 143 +++++++++++++++++++++++++++++++
>  5 files changed, 237 insertions(+)

Reviewed-by: Richard Henderson <address@hidden>


r~