[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v1 0/2] s390x/tcg: STFLE fixes
From: |
Cornelia Huck |
Subject: |
Re: [qemu-s390x] [PATCH v1 0/2] s390x/tcg: STFLE fixes |
Date: |
Mon, 3 Jun 2019 09:02:25 +0200 |
On Fri, 31 May 2019 16:56:06 +0200
David Hildenbrand <address@hidden> wrote:
> While testing vector instructions, I ran into various issues with
> user space binaries compiled with more recent compiler versions like
>
> # gunzip /usr/share/man/man1/hexdump.1.gz
> <dhildenb> *** stack smashing detected ***: <unknown> terminated
>
> Turns out:
> a) the STFLE instruction in semi-broken on the first invocation
> b) the code expects a different STFLE behavior than documented in the PoP
>
> Fix a) and make sure the code works by adjusting b).
>
So your problems actually did not have anything to do with vector
instructions and were simply exposed by running binaries compiled with a
more recent compiler version, right? Interesting :)
> David Hildenbrand (2):
> s390x/tcg: Fix max_byte detection for stfle
> s390x/tcg: Store only the necessary amount of doublewords for STFLE
>
> target/s390x/misc_helper.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
Do you want to include these in a pull request, or should I pick them
up myself?
- Re: [qemu-s390x] [PATCH v1 0/2] s390x/tcg: STFLE fixes,
Cornelia Huck <=