[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PULL 11/16] hw/usb-storage: Use the QOM DEVICE() macro to
From: |
Laurent Vivier |
Subject: |
[qemu-s390x] [PULL 11/16] hw/usb-storage: Use the QOM DEVICE() macro to access DeviceState.qdev |
Date: |
Thu, 6 Jun 2019 13:06:20 +0200 |
From: Philippe Mathieu-Daudé <address@hidden>
Rather than looking inside the definition of a DeviceState with
"s->qdev", use the QOM prefered style: "DEVICE(s)".
This patch was generated using the following Coccinelle script:
// Use DEVICE() macros to access DeviceState.qdev
@use_device_macro_to_access_qdev@
expression obj;
identifier dev;
@@
-&obj->dev.qdev
+DEVICE(obj)
Suggested-by: Peter Maydell <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Gerd Hoffmann <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
hw/usb/dev-storage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
index cd5551d94f35..0e4e93ef1673 100644
--- a/hw/usb/dev-storage.c
+++ b/hw/usb/dev-storage.c
@@ -616,7 +616,7 @@ static void usb_msd_storage_realize(USBDevice *dev, Error
**errp)
* The hack is probably a bad idea.
*/
blk_ref(blk);
- blk_detach_dev(blk, &s->dev.qdev);
+ blk_detach_dev(blk, DEVICE(s));
s->conf.blk = NULL;
usb_desc_create_serial(dev);
--
2.21.0
- [qemu-s390x] [PULL 00/16] Trivial branch patches, Laurent Vivier, 2019/06/06
- [qemu-s390x] [PULL 06/16] docs/devel/build-system: Update an example, Laurent Vivier, 2019/06/06
- [qemu-s390x] [PULL 03/16] vhost: fix incorrect print type, Laurent Vivier, 2019/06/06
- [qemu-s390x] [PULL 07/16] hw/scsi/vmw_pvscsi: Use qbus_reset_all() directly, Laurent Vivier, 2019/06/06
- [qemu-s390x] [PULL 11/16] hw/usb-storage: Use the QOM DEVICE() macro to access DeviceState.qdev,
Laurent Vivier <=
- [qemu-s390x] [PULL 08/16] hw/pci-bridge: Use the QOM BUS() macro to access BusState.qbus, Laurent Vivier, 2019/06/06
- [qemu-s390x] [PULL 09/16] hw/s390x/event-facility: Use the QOM BUS() macro to access BusState.qbus, Laurent Vivier, 2019/06/06
- [qemu-s390x] [PULL 04/16] util: Adjust qemu_guest_getrandom_nofail for Coverity, Laurent Vivier, 2019/06/06
- [qemu-s390x] [PULL 13/16] hw/audio/ac97: Use the QOM DEVICE() macro to access DeviceState.qdev, Laurent Vivier, 2019/06/06
- [qemu-s390x] [PULL 05/16] test: Fix make target check-report.tap, Laurent Vivier, 2019/06/06
- [qemu-s390x] [PULL 16/16] hw/watchdog/wdt_i6300esb: Use DEVICE() macro to access DeviceState.qdev, Laurent Vivier, 2019/06/06
- [qemu-s390x] [PULL 12/16] hw/vfio/pci: Use the QOM DEVICE() macro to access DeviceState.qdev, Laurent Vivier, 2019/06/06
- [qemu-s390x] [PULL 10/16] hw/isa: Use the QOM DEVICE() macro to access DeviceState.qdev, Laurent Vivier, 2019/06/06
- [qemu-s390x] [PULL 14/16] hw/sd: Use the QOM BUS() macro to access BusState.qbus, Laurent Vivier, 2019/06/06