Re: [qemu-s390x] [PATCH v3 01/33] Create Resettable QOM interface

[Cornelia Huck]

On Tue, 30 Jul 2019 14:44:21 +0100
Peter Maydell <address@hidden> wrote:

> On Tue, 30 Jul 2019 at 14:42, Cornelia Huck <address@hidden> wrote:
> >
> > On Mon, 29 Jul 2019 16:56:22 +0200
> > Damien Hedde <address@hidden> wrote:
> >
> > (...)
> >  
> > > +/*
> > > + * ResettableClass:
> > > + * Interface for resettable objects.
> > > + *
> > > + * The reset operation is divided in several phases each represented by a
> > > + * method.
> > > + *
> > > + * Each Ressetable must maintain a reset counter in its state, 3 methods 
> > > allows
> > > + * to interact with it.
> > > + *
> > > + * @phases.init: should reset local state only. Takes a bool @cold 
> > > argument
> > > + * specifying whether the reset is cold or warm. It must not do 
> > > side-effect
> > > + * on others objects.  
> >
> > I'm having a hard time figuring out what a 'cold' or a 'warm' reset is
> > supposed to be... can you add a definition/guideline somewhere?  
> 
> Generally "cold" reset is "power on" and "warm" is "we were already
> powered-on, but somebody flipped a reset line somewhere".

Ok, that makes sense... my main concern is to distinguish that in a
generic way, as it is a generic interface. What about adding something
like:

"A 'cold' reset means that the object to be reset is initially reset; a 'warm'
reset means that the object to be reset has already been initialized."

Or is that again too generic?