Re: [qemu-s390x] [Qemu-devel] [PATCH v9 14/20] memory: Access MemoryRegion with endianness

[Richard Henderson]

On 8/23/19 11:36 AM, Tony Nguyen wrote:
> Preparation for collapsing the two byte swaps adjust_endianness and
> handle_bswap into the former.
> 
> Call memory_region_dispatch_{read|write} with endianness encoded into
> the "MemOp op" operand.
> 
> This patch does not change any behaviour as
> memory_region_dispatch_{read|write} is yet to handle the endianness.
> 
> Once it does handle endianness, callers with byte swaps can collapse
> them into adjust_endianness.
> 
> Signed-off-by: Tony Nguyen <address@hidden>
> ---
>  accel/tcg/cputlb.c       |  8 ++++++--
>  exec.c                   | 13 +++++++++++--
>  hw/intc/armv7m_nvic.c    | 15 ++++++++-------
>  hw/s390x/s390-pci-inst.c |  6 ++++--
>  hw/vfio/pci-quirks.c     |  5 +++--
>  hw/virtio/virtio-pci.c   |  6 ++++--
>  include/exec/memory.h    |  3 +++
>  memory.c                 | 18 ++++++++++++++++++
>  memory_ldst.inc.c        | 24 ++++++++++++++++++------
>  9 files changed, 75 insertions(+), 23 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~