[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [Qemu-devel] [PATCH v1 2/2] tcg: Factor out probe_write
|
From: |
Richard Henderson |
|
Subject: |
Re: [qemu-s390x] [Qemu-devel] [PATCH v1 2/2] tcg: Factor out probe_write() logic into probe_access() |
|
Date: |
Wed, 28 Aug 2019 07:52:57 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 8/28/19 4:10 AM, David Hildenbrand wrote:
> +void *probe_access(CPUArchState *env, target_ulong addr, int size,
> + MMUAccessType access_type, int mmu_idx, uintptr_t retaddr)
> {
> CPUState *cpu = env_cpu(env);
> CPUClass *cc;
> + int flags;
>
> g_assert(-(addr | TARGET_PAGE_MASK) >= size);
> + g_assert(mmu_idx == MMU_USER_IDX);
We ignore mmu_idx pretty much everywhere else.
Why bother now?
r~