[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PATCH v2 11/28] s390x/tcg: MVCS/MVCP: Properly wrap the le
From: |
David Hildenbrand |
Subject: |
[qemu-s390x] [PATCH v2 11/28] s390x/tcg: MVCS/MVCP: Properly wrap the length |
Date: |
Fri, 6 Sep 2019 09:57:33 +0200 |
... and don't perform any move in case the length is zero.
Signed-off-by: David Hildenbrand <address@hidden>
---
target/s390x/mem_helper.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index 041d01d63d..de5e69b500 100644
--- a/target/s390x/mem_helper.c
+++ b/target/s390x/mem_helper.c
@@ -1973,10 +1973,13 @@ uint32_t HELPER(mvcs)(CPUS390XState *env, uint64_t l,
uint64_t a1, uint64_t a2)
s390_program_interrupt(env, PGM_SPECIAL_OP, ILEN_AUTO, ra);
}
+ l = wrap_length(env, l);
if (l > 256) {
/* max 256 */
l = 256;
cc = 3;
+ } else if (!l) {
+ return cc;
}
/* XXX replace w/ memcpy */
@@ -2002,10 +2005,13 @@ uint32_t HELPER(mvcp)(CPUS390XState *env, uint64_t l,
uint64_t a1, uint64_t a2)
s390_program_interrupt(env, PGM_SPECIAL_OP, ILEN_AUTO, ra);
}
+ l = wrap_length(env, l);
if (l > 256) {
/* max 256 */
l = 256;
cc = 3;
+ } else if (!l) {
+ return cc;
}
/* XXX replace w/ memcpy */
--
2.21.0
- Re: [qemu-s390x] [Qemu-devel] [PATCH v2 06/28] s390x/tcg: MVC: Use is_destructive_overlap(), (continued)
- [qemu-s390x] [PATCH v2 07/28] s390x/tcg: MVPG: Check for specification exceptions, David Hildenbrand, 2019/09/06
- [qemu-s390x] [PATCH v2 08/28] s390x/tcg: MVPG: Properly wrap the addresses, David Hildenbrand, 2019/09/06
- [qemu-s390x] [PATCH v2 09/28] s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time, David Hildenbrand, 2019/09/06
- [qemu-s390x] [PATCH v2 10/28] s390x/tcg: MVCS/MVCP: Check for special operation exceptions, David Hildenbrand, 2019/09/06
- [qemu-s390x] [PATCH v2 11/28] s390x/tcg: MVCS/MVCP: Properly wrap the length,
David Hildenbrand <=
- [qemu-s390x] [PATCH v2 12/28] s390x/tcg: MVST: Check for specification exceptions, David Hildenbrand, 2019/09/06
- [qemu-s390x] [PATCH v2 13/28] s390x/tcg: MVST: Fix storing back the addresses to registers, David Hildenbrand, 2019/09/06
- [qemu-s390x] [PATCH v2 14/28] s390x/tcg: Always use MMU_USER_IDX for CONFIG_USER_ONLY, David Hildenbrand, 2019/09/06
- [qemu-s390x] [PATCH v2 15/28] s390x/tcg: Fault-safe memset, David Hildenbrand, 2019/09/06