Re: [qemu-s390x] [Qemu-devel] [PATCH v3 17/29] s390x/tcg: Fault-safe memmove

[Richard Henderson]

On 9/16/19 9:57 AM, David Hildenbrand wrote:
> Replace fast_memmove() variants by access_memmove() variants, that
> first try to probe access to all affected pages (maximum is two pages).
> 
> Introduce access_get_byte()/access_set_byte(). We might be able to speed
> up memmove in special cases even further (do single-byte access, use
> memmove() for remaining bytes in page), however, we'll skip that for now.
> 
> In MVCOS, simply always call access_memmove_as() and drop the TODO
> about LAP. LAP is already handled in the MMU.
> 
> Get rid of adj_len_to_page(), which is now unused.
> 
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
>  target/s390x/mem_helper.c | 232 ++++++++++++++++++++++----------------
>  1 file changed, 133 insertions(+), 99 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~