[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PULL 12/34] s390x/tcg: MVCS/MVCP: Properly wrap the length
From: |
Cornelia Huck |
Subject: |
[qemu-s390x] [PULL 12/34] s390x/tcg: MVCS/MVCP: Properly wrap the length |
Date: |
Thu, 19 Sep 2019 14:40:53 +0200 |
From: David Hildenbrand <address@hidden>
... and don't perform any move in case the length is zero.
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
target/s390x/mem_helper.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index 320e9ee65c88..41d7336a1a7a 100644
--- a/target/s390x/mem_helper.c
+++ b/target/s390x/mem_helper.c
@@ -1980,10 +1980,13 @@ uint32_t HELPER(mvcs)(CPUS390XState *env, uint64_t l,
uint64_t a1, uint64_t a2)
s390_program_interrupt(env, PGM_SPECIAL_OP, ILEN_AUTO, ra);
}
+ l = wrap_length32(env, l);
if (l > 256) {
/* max 256 */
l = 256;
cc = 3;
+ } else if (!l) {
+ return cc;
}
/* XXX replace w/ memcpy */
@@ -2009,10 +2012,13 @@ uint32_t HELPER(mvcp)(CPUS390XState *env, uint64_t l,
uint64_t a1, uint64_t a2)
s390_program_interrupt(env, PGM_SPECIAL_OP, ILEN_AUTO, ra);
}
+ l = wrap_length32(env, l);
if (l > 256) {
/* max 256 */
l = 256;
cc = 3;
+ } else if (!l) {
+ return cc;
}
/* XXX replace w/ memcpy */
--
2.20.1
- [qemu-s390x] [PULL 22/34] s390x/tcg: XC: Fault-safe handling, (continued)
- [qemu-s390x] [PULL 22/34] s390x/tcg: XC: Fault-safe handling, Cornelia Huck, 2019/09/19
- [qemu-s390x] [PULL 19/34] s390x/tcg: MVC: Fault-safe handling on destructive overlaps, Cornelia Huck, 2019/09/19
- [qemu-s390x] [PULL 18/34] s390x/tcg: MVCS/MVCP: Use access_memmove(), Cornelia Huck, 2019/09/19
- [qemu-s390x] [PULL 13/34] s390x/tcg: MVST: Check for specification exceptions, Cornelia Huck, 2019/09/19
- [qemu-s390x] [PULL 10/34] s390x/tcg: MVCS/MVCP: Check for special operation exceptions, Cornelia Huck, 2019/09/19
- [qemu-s390x] [PULL 07/34] s390x/tcg: MVPG: Check for specification exceptions, Cornelia Huck, 2019/09/19
- [qemu-s390x] [PULL 15/34] s390x/tcg: Always use MMU_USER_IDX for CONFIG_USER_ONLY, Cornelia Huck, 2019/09/19
- [qemu-s390x] [PULL 14/34] s390x/tcg: MVST: Fix storing back the addresses to registers, Cornelia Huck, 2019/09/19
- [qemu-s390x] [PULL 16/34] s390x/tcg: Fault-safe memset, Cornelia Huck, 2019/09/19
- [qemu-s390x] [PULL 11/34] s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode, Cornelia Huck, 2019/09/19
- [qemu-s390x] [PULL 12/34] s390x/tcg: MVCS/MVCP: Properly wrap the length,
Cornelia Huck <=
- [qemu-s390x] [PULL 09/34] s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time, Cornelia Huck, 2019/09/19
- [qemu-s390x] [PULL 06/34] s390x/tcg: MVC: Use is_destructive_overlap(), Cornelia Huck, 2019/09/19
- [qemu-s390x] [PULL 08/34] s390x/tcg: MVPG: Properly wrap the addresses, Cornelia Huck, 2019/09/19
- [qemu-s390x] [PULL 04/34] s390x/tcg: MVCL: Process max 4k bytes at a time, Cornelia Huck, 2019/09/19
- [qemu-s390x] [PULL 05/34] s390x/tcg: MVC: Increment the length once, Cornelia Huck, 2019/09/19
- [qemu-s390x] [PULL 03/34] s390x/tcg: MVCL: Detect destructive overlaps, Cornelia Huck, 2019/09/19
- [qemu-s390x] [PULL 01/34] s390x/tcg: Reset exception_index to -1 instead of 0, Cornelia Huck, 2019/09/19
- [qemu-s390x] [PULL 02/34] s390x/tcg: MVCL: Zero out unused bits of address, Cornelia Huck, 2019/09/19
- Re: [PULL 00/34] s390x update, Peter Maydell, 2019/09/20