[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [Qemu-devel] [PATCH v1] tests/tcg: target/s390x: Test M
|
From: |
Richard Henderson |
|
Subject: |
Re: [qemu-s390x] [Qemu-devel] [PATCH v1] tests/tcg: target/s390x: Test MVC |
|
Date: |
Thu, 19 Sep 2019 09:01:13 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/19/19 2:41 AM, David Hildenbrand wrote:
>> + /* prepare the buffers - two consecutive pages */
>> + src = valloc(ALLOC_SIZE);
>> + dst = valloc(ALLOC_SIZE);
>
> If anybody cares, I can convert the obsolete valloc into a
> posix_memalign(&src, 4096, ALLOC_SIZE) etc.
I don't care. It may be obsolete, but it still works.
If you were to change it to anything I would think mmap
instead of using mprotect on the heap at all...
Reviewed-by: Richard Henderson <address@hidden>
r~