[PATCH v3 05/25] scripts: add coccinelle script to fix error_append_hint usage

[Vladimir Sementsov-Ogievskiy]

error_append_hint will not work, if errp == &fatal_error, as program
will exit before error_append_hint call. Fix this by use of special
macro ERRP_FUNCTION_BEGIN.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---

CC: John Snow <address@hidden>
CC: Kevin Wolf <address@hidden>
CC: Max Reitz <address@hidden>
CC: Fam Zheng <address@hidden>
CC: Jeff Cody <address@hidden>
CC: "Marc-André Lureau" <address@hidden>
CC: Paolo Bonzini <address@hidden>
CC: Greg Kurz <address@hidden>
CC: Subbaraya Sundeep <address@hidden>
CC: Peter Maydell <address@hidden>
CC: Paul Burton <address@hidden>
CC: Aleksandar Rikalo <address@hidden>
CC: "Michael S. Tsirkin" <address@hidden>
CC: Marcel Apfelbaum <address@hidden>
CC: Mark Cave-Ayland <address@hidden>
CC: David Gibson <address@hidden>
CC: Yuval Shaia <address@hidden>
CC: Cornelia Huck <address@hidden>
CC: Eric Farman <address@hidden>
CC: Richard Henderson <address@hidden>
CC: David Hildenbrand <address@hidden>
CC: Halil Pasic <address@hidden>
CC: Christian Borntraeger <address@hidden>
CC: Gerd Hoffmann <address@hidden>
CC: Alex Williamson <address@hidden>
CC: Markus Armbruster <address@hidden>
CC: Michael Roth <address@hidden>
CC: Juan Quintela <address@hidden>
CC: "Dr. David Alan Gilbert" <address@hidden>
CC: Eric Blake <address@hidden>
CC: Jason Wang <address@hidden>
CC: "Daniel P. Berrangé" <address@hidden>
CC: Eduardo Habkost <address@hidden>
CC: address@hidden
CC: address@hidden
CC: address@hidden
CC: address@hidden
CC: address@hidden
CC: address@hidden

 .../fix-error_append_hint-usage.cocci         | 25 +++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 scripts/coccinelle/fix-error_append_hint-usage.cocci

diff --git a/scripts/coccinelle/fix-error_append_hint-usage.cocci 
b/scripts/coccinelle/fix-error_append_hint-usage.cocci
new file mode 100644
index 0000000000..327fe6098c
--- /dev/null
+++ b/scripts/coccinelle/fix-error_append_hint-usage.cocci
@@ -0,0 +1,25 @@
+@rule0@
+// Add invocation to errp-functions
+identifier fn;
+@@
+
+ fn(..., Error **errp, ...)
+ {
++   ERRP_FUNCTION_BEGIN();
+    <+...
+    error_append_hint(errp, ...);
+    ...+>
+ }
+
+@@
+// Drop doubled invocation
+identifier rule0.fn;
+@@
+
+ fn(...)
+{
+    ERRP_FUNCTION_BEGIN();
+-   ERRP_FUNCTION_BEGIN();
+    ...
+}
+
-- 
2.21.0