Re: [PATCH v3 09/18] target/s390x: Remove exc argument to mmu_translate_asce

[David Hildenbrand]

On 26.09.19 18:26, Richard Henderson wrote:
> Now that mmu_translate_asce returns the exception instead of
> raising it, the argument is unused.
> 
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target/s390x/mmu_helper.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
> index b783c62bd7..ed6570db62 100644
> --- a/target/s390x/mmu_helper.c
> +++ b/target/s390x/mmu_helper.c
> @@ -113,7 +113,7 @@ static inline int read_table_entry(hwaddr gaddr, uint64_t 
> *entry)
>  
>  static int mmu_translate_asce(CPUS390XState *env, target_ulong vaddr,
>                                uint64_t asc, uint64_t asce, target_ulong 
> *raddr,
> -                              int *flags, int rw, bool exc)
> +                              int *flags, int rw)
>  {
>      const bool edat1 = (env->cregs[0] & CR0_EDAT) &&
>                         s390_has_feat(S390_FEAT_EDAT);
> @@ -402,7 +402,7 @@ int mmu_translate(CPUS390XState *env, target_ulong vaddr, 
> int rw, uint64_t asc,
>      }
>  
>      /* perform the DAT translation */
> -    r = mmu_translate_asce(env, vaddr, asc, asce, raddr, flags, rw, exc);
> +    r = mmu_translate_asce(env, vaddr, asc, asce, raddr, flags, rw);
>      if (unlikely(r)) {
>          if (exc) {
>              trigger_access_exception(env, r, ilen, tec);
> 

Very nice, I missed that

Reviewed-by: David Hildenbrand <address@hidden>

-- 

Thanks,

David / dhildenb