[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 05/12] s390x: sclp: fix error handling for oversize control blocks
From: |
Christian Borntraeger |
Subject: |
[PULL 05/12] s390x: sclp: fix error handling for oversize control blocks |
Date: |
Mon, 30 Sep 2019 15:19:48 +0200 |
From: Janosch Frank <address@hidden>
Requests over 4k are not a spec exception.
Signed-off-by: Janosch Frank <address@hidden>
Reviewed-by: Jason J. Herne <address@hidden>
Message-Id: <address@hidden>
Acked-by: David Hildenbrand <address@hidden>
Signed-off-by: Christian Borntraeger <address@hidden>
---
hw/s390x/sclp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c
index 73244c938b10..abb6e5011f9c 100644
--- a/hw/s390x/sclp.c
+++ b/hw/s390x/sclp.c
@@ -213,8 +213,7 @@ int sclp_service_call(CPUS390XState *env, uint64_t sccb,
uint32_t code)
cpu_physical_memory_read(sccb, &work_sccb, sccb_len);
/* Valid sccb sizes */
- if (be16_to_cpu(work_sccb.h.length) < sizeof(SCCBHeader) ||
- be16_to_cpu(work_sccb.h.length) > SCCB_SIZE) {
+ if (be16_to_cpu(work_sccb.h.length) < sizeof(SCCBHeader)) {
r = -PGM_SPECIFICATION;
goto out;
}
--
2.21.0
- [PULL 00/12] s390x qemu updates 20190930, Christian Borntraeger, 2019/09/30
- [PULL 01/12] MAINTAINERS: Update S390 PCI Maintainer, Christian Borntraeger, 2019/09/30
- [PULL 08/12] kvm: extract kvm_log_clear_one_slot, Christian Borntraeger, 2019/09/30
- [PULL 02/12] s390: PCI: fix IOMMU region init, Christian Borntraeger, 2019/09/30
- [PULL 03/12] s390x: sclp: refactor invalid command check, Christian Borntraeger, 2019/09/30
- [PULL 07/12] configure: Remove s390 (31-bit mode) from the list of supported CPUs, Christian Borntraeger, 2019/09/30
- [PULL 09/12] kvm: clear dirty bitmaps from all overlapping memslots, Christian Borntraeger, 2019/09/30
- [PULL 05/12] s390x: sclp: fix error handling for oversize control blocks,
Christian Borntraeger <=
- [PULL 12/12] s390/kvm: split kvm mem slots at 4TB, Christian Borntraeger, 2019/09/30
- [PULL 11/12] s390: do not call memory_region_allocate_system_memory() multiple times, Christian Borntraeger, 2019/09/30
- [PULL 06/12] s390x: sclp: Report insufficient SCCB length, Christian Borntraeger, 2019/09/30
- [PULL 04/12] s390x: sclp: boundary check, Christian Borntraeger, 2019/09/30
- [PULL 10/12] kvm: split too big memory section on several memslots, Christian Borntraeger, 2019/09/30