[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/18] target/s390x: Add ilen to unwind data
From: |
David Hildenbrand |
Subject: |
Re: [PATCH v3 02/18] target/s390x: Add ilen to unwind data |
Date: |
Mon, 30 Sep 2019 19:13:23 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 30.09.19 18:15, Richard Henderson wrote:
> On 9/30/19 8:42 AM, David Hildenbrand wrote:
>>> Of course, but it's no different with this case than any other. If the
>>> interrupt has already been handled, then we will simply restart the next TB
>>> as
>>> per normal.
>> Yeah, I was mostly concerned that "the next TB" will be "the next
>> instruction" and not "the original instruction again".
>
> Ah, well, that's easy. The next TB will start from psw.addr, and when we
> cpu_loop_exit_restore(), psw.addr will be set to the current instruction.
>
> This is exactly the same as when we raise a PGM_ADDRESSING exception which
> needs to be restarted after the kernel swaps in the page.
>
Now that I think about it, this makes perfect sense :)
So it's mostly checking if there is an exception (like you said) and
then doing a cpu_loop_exit_restore() (if I'm not wrong, but I'll have to
look at the details).
--
Thanks,
David / dhildenb
- [PATCH v3 00/18] target/s390: Use tcg unwinding for ilen, Richard Henderson, 2019/09/26
- [PATCH v3 02/18] target/s390x: Add ilen to unwind data, Richard Henderson, 2019/09/26
- Re: [PATCH v3 02/18] target/s390x: Add ilen to unwind data, David Hildenbrand, 2019/09/27
- Re: [PATCH v3 02/18] target/s390x: Add ilen to unwind data, Richard Henderson, 2019/09/27
- Re: [PATCH v3 02/18] target/s390x: Add ilen to unwind data, David Hildenbrand, 2019/09/30
- Re: [PATCH v3 02/18] target/s390x: Add ilen to unwind data, Richard Henderson, 2019/09/30
- Re: [PATCH v3 02/18] target/s390x: Add ilen to unwind data, David Hildenbrand, 2019/09/30
- Re: [PATCH v3 02/18] target/s390x: Add ilen to unwind data, Richard Henderson, 2019/09/30
- Re: [PATCH v3 02/18] target/s390x: Add ilen to unwind data,
David Hildenbrand <=
[PATCH v3 01/18] target/s390x: Truncate 32-bit psw_addr before creating TB, Richard Henderson, 2019/09/26
[PATCH v3 07/18] target/s390x: Handle tec in s390_cpu_tlb_fill, Richard Henderson, 2019/09/26
[PATCH v3 08/18] target/s390: Return exception from mmu_translate_real, Richard Henderson, 2019/09/26
[PATCH v3 03/18] target/s390x: Remove ilen parameter from tcg_s390_program_interrupt, Richard Henderson, 2019/09/26