[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] s390x/tcg: MVCL: Exit to main loop if requested
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2] s390x/tcg: MVCL: Exit to main loop if requested |
Date: |
Fri, 4 Oct 2019 13:11:08 +0100 |
On Fri, 4 Oct 2019 at 09:02, David Hildenbrand <address@hidden> wrote:
> So shall we leave this patch as-is (adding a summary of what you
> explained to the description) or shall we somehow factor out the
> TCG-internal-thingy check?
Nothing else in target code touches the icount data structures,
so if this s390 insn needs to make this check I think it ought
to do it by calling a function implemented by the tcg code;
that can then have a good name that describes what it's doing
and a doc comment explaining the reason we need to have it.
thanks
-- PMM
- [PATCH v2] s390x/tcg: MVCL: Exit to main loop if requested, David Hildenbrand, 2019/10/02
- Re: [PATCH v2] s390x/tcg: MVCL: Exit to main loop if requested, Alex Bennée, 2019/10/02
- Re: [PATCH v2] s390x/tcg: MVCL: Exit to main loop if requested, Richard Henderson, 2019/10/02
- Re: [PATCH v2] s390x/tcg: MVCL: Exit to main loop if requested, David Hildenbrand, 2019/10/02
- Re: [PATCH v2] s390x/tcg: MVCL: Exit to main loop if requested, Richard Henderson, 2019/10/02
- Re: [PATCH v2] s390x/tcg: MVCL: Exit to main loop if requested, David Hildenbrand, 2019/10/04
- Re: [PATCH v2] s390x/tcg: MVCL: Exit to main loop if requested, Alex Bennée, 2019/10/04
- Re: [PATCH v2] s390x/tcg: MVCL: Exit to main loop if requested,
Peter Maydell <=
- Re: [PATCH v2] s390x/tcg: MVCL: Exit to main loop if requested, David Hildenbrand, 2019/10/04
- Re: [PATCH v2] s390x/tcg: MVCL: Exit to main loop if requested, Alex Bennée, 2019/10/04
- Re: [PATCH v2] s390x/tcg: MVCL: Exit to main loop if requested, Richard Henderson, 2019/10/04