[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 03/10] hw/ppc/spapr_rtas: Remove local variable
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 03/10] hw/ppc/spapr_rtas: Remove local variable |
Date: |
Tue, 21 Jan 2020 12:03:42 +0100 |
We only access this variable in the RTAS_SYSPARM_SPLPAR_CHARACTERISTICS
case. Use it in place and remove the local declaration.
Suggested-by: Greg Kurz <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
v2: Do not reduce MachineState variable scope (David Gibson)
---
hw/ppc/spapr_rtas.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c
index 6f06e9d7fe..85135e0e1a 100644
--- a/hw/ppc/spapr_rtas.c
+++ b/hw/ppc/spapr_rtas.c
@@ -268,7 +268,6 @@ static void rtas_ibm_get_system_parameter(PowerPCCPU *cpu,
{
PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(cpu);
MachineState *ms = MACHINE(spapr);
- unsigned int max_cpus = ms->smp.max_cpus;
target_ulong parameter = rtas_ld(args, 0);
target_ulong buffer = rtas_ld(args, 1);
target_ulong length = rtas_ld(args, 2);
@@ -280,10 +279,10 @@ static void rtas_ibm_get_system_parameter(PowerPCCPU *cpu,
"DesMem=%" PRIu64 ","
"DesProcs=%d,"
"MaxPlatProcs=%d",
- max_cpus,
+ ms->smp.max_cpus,
ms->ram_size / MiB,
ms->smp.cpus,
- max_cpus);
+ ms->smp.max_cpus);
if (pcc->n_host_threads > 0) {
char *hostthr_val, *old = param_val;
--
2.21.1
- [PATCH v2 00/10] Cleanups around the 'current_machine' global variable, Philippe Mathieu-Daudé, 2020/01/21
- [PATCH v2 01/10] hw/ppc/spapr_rtas: Use local MachineState variable, Philippe Mathieu-Daudé, 2020/01/21
- [PATCH v2 02/10] hw/ppc/spapr_rtas: Access MachineState via SpaprMachineState argument, Philippe Mathieu-Daudé, 2020/01/21
- [PATCH v2 03/10] hw/ppc/spapr_rtas: Remove local variable,
Philippe Mathieu-Daudé <=
- [PATCH v2 04/10] target/arm/kvm: Use CPUState::kvm_state in kvm_arm_pmu_supported(), Philippe Mathieu-Daudé, 2020/01/21
- [PATCH v2 05/10] target/s390x: Remove duplicated ifdef macro, Philippe Mathieu-Daudé, 2020/01/21
- [PATCH v2 06/10] qom/object: Display more helpful message when a parent is missing, Philippe Mathieu-Daudé, 2020/01/21
- [PATCH v2 07/10] qdev: Abort if the root machine container is missing, Philippe Mathieu-Daudé, 2020/01/21
- [PATCH v2 08/10] accel: Introduce the current_accel() wrapper, Philippe Mathieu-Daudé, 2020/01/21