[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/3] hw: Make MachineClass::is_default a boolean type
From: |
Thomas Huth |
Subject: |
Re: [PATCH v4 2/3] hw: Make MachineClass::is_default a boolean type |
Date: |
Mon, 10 Feb 2020 10:22:45 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 07/02/2020 17.19, Philippe Mathieu-Daudé wrote:
> There's no good reason for it to be type int, change it to bool.
>
> Suggested-by: Richard Henderson <address@hidden>
> Reviewed-by: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> v4:
> - fixed incorrect changes to max_cpus (Laurent)
> - describe field
> ---
[...]
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index fa12203079..9088db8fb6 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -423,7 +423,7 @@ static void pc_i440fx_5_0_machine_options(MachineClass *m)
> PCMachineClass *pcmc = PC_MACHINE_CLASS(m);
> pc_i440fx_machine_options(m);
> m->alias = "pc";
> - m->is_default = 1;
> + m->is_default = true;
> pcmc->default_cpu_version = 1;
> }
>
> @@ -434,7 +434,7 @@ static void pc_i440fx_4_2_machine_options(MachineClass *m)
> {
> pc_i440fx_5_0_machine_options(m);
> m->alias = NULL;
> - m->is_default = 0;
> + m->is_default = false;
> compat_props_add(m->compat_props, hw_compat_4_2, hw_compat_4_2_len);
> compat_props_add(m->compat_props, pc_compat_4_2, pc_compat_4_2_len);
> }
> @@ -446,7 +446,7 @@ static void pc_i440fx_4_1_machine_options(MachineClass *m)
> {
> pc_i440fx_4_2_machine_options(m);
Since we're calling pc_i440fx_4_2_machine_options() here...
> m->alias = NULL;
> - m->is_default = 0;
> + m->is_default = false;
... you could even remove this line now...
> compat_props_add(m->compat_props, hw_compat_4_1, hw_compat_4_1_len);
> compat_props_add(m->compat_props, pc_compat_4_1, pc_compat_4_1_len);
> }
> @@ -459,7 +459,7 @@ static void pc_i440fx_4_0_machine_options(MachineClass *m)
> PCMachineClass *pcmc = PC_MACHINE_CLASS(m);
> pc_i440fx_4_1_machine_options(m);
> m->alias = NULL;
> - m->is_default = 0;
> + m->is_default = false;
... and this one, too.
> pcmc->default_cpu_version = CPU_VERSION_LEGACY;
> compat_props_add(m->compat_props, hw_compat_4_0, hw_compat_4_0_len);
> compat_props_add(m->compat_props, pc_compat_4_0, pc_compat_4_0_len);
> @@ -473,7 +473,7 @@ static void pc_i440fx_3_1_machine_options(MachineClass *m)
> PCMachineClass *pcmc = PC_MACHINE_CLASS(m);
>
> pc_i440fx_4_0_machine_options(m);
> - m->is_default = 0;
> + m->is_default = false;
dito.
But that could also be done in a later patch, so:
Reviewed-by: Thomas Huth <address@hidden>
- Re: Tricore default machine, (continued)
- Re: Tricore default machine, Philippe Mathieu-Daudé, 2020/02/10
- Re: Tricore default machine, Thomas Huth, 2020/02/10
- Re: Tricore default machine, Bastian Koppelmann, 2020/02/10
- Re: Tricore default machine, Peter Maydell, 2020/02/10
- Re: Tricore default machine, Philippe Mathieu-Daudé, 2020/02/10
[PATCH v4 2/3] hw: Make MachineClass::is_default a boolean type, Philippe Mathieu-Daudé, 2020/02/07
[PATCH v4 3/3] vl: Abort if multiple machines are registered as default, Philippe Mathieu-Daudé, 2020/02/07
Re: [PATCH v4 0/3] Make MachineClass::is_default boolean, refuse multiple default machines, Eduardo Habkost, 2020/02/07