Re: [kvm-unit-tests PATCH v3] s390x: Add stsi 3.2.2 tests

[Janosch Frank]

On 3/31/20 7:24 PM, David Hildenbrand wrote:
> On 31.03.20 11:35, Cornelia Huck wrote:
>> On Tue, 31 Mar 2020 03:14:56 -0400
>> Janosch Frank <address@hidden> wrote:
>>
>>> Subcode 3.2.2 is handled by KVM/QEMU and should therefore be tested
>>> a bit more thorough.
>>
>> s/thorough/thoroughly/ ?
> 
> I fixed that up for now.

Thanks

> 
> [...]
> 
>>> +   if (data->vm[0].ext_name_encoding != 2) {
>>> +           report_skip("Extended VM names are not UTF-8.");
>>
>> Do we expect this to be anything other than UTF-8?
> 
> I'm not a fan of hard-coding things that can change to other valid
> values. No strong feelings though. I'll let Janosch decide :)
> 

I'd like to keep it as is.

signature.asc
Description: OpenPGP digital signature