Re: [PATCH v1 2/8] s390/sclp: check sccb len before filling in data

[Collin Walling]

On 5/11/20 10:44 AM, David Hildenbrand wrote:
> On 11.05.20 16:36, Janosch Frank wrote:
> > On 5/9/20 1:08 AM, Collin Walling wrote:
> > > The SCCB must be checked for a sufficient length before it is filled
> > > with any data. If the length is insufficient, then the SCLP command
> > > is suppressed and the proper response code is set in the SCCB header.
> > >
> > > Signed-off-by: Collin Walling <address@hidden>
> >
> > Fixes tag?
> > Reviewed-by: Janosch Frank <address@hidden>
>
> This is not a fix AFAIKs.
> sclp_service_call()/sclp_service_call_protected() always supplies a full
> SCCB of exactly 4k size.

Right. This is more-or-less a preparation patch for the extended-length
SCCB stuff which allows an SCCB > 4k.

The Linux kernel always provides a 4k SSCB today, so this patch
more-or-less makes the code AR compliant.

--
--
Regards,
Collin

Stay safe and stay healthy