Re: [PATCH v1 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

[Collin Walling]

On 5/12/20 12:08 PM, Cornelia Huck wrote:
> On Fri,  8 May 2020 19:08:15 -0400
> Collin Walling <address@hidden> wrote:
>
> > Collin L. Walling (8):
> >    s390/sclp: remove SCLPDevice param from prepare_cpu_entries
>
> This looks like a simple cleanup...
>
> >    s390/sclp: check sccb len before filling in data
>
> ...and that like a simple fix (for a problem that currently does not
> trigger.) Would it help or hinder you if I went ahead and queued these
> two patches already?

Let's wait for one more round if that's okay. I left a response to
David's feedback that may-or-may not add one more cleanup that can
be squeezed into patch 1 if it makes sense.

Thanks, though! :)

> >    s390/sclp: rework sclp boundary and length checks
> >    s390/sclp: read sccb from mem based on sccb length
> >    s390/sclp: use cpu offset to locate cpu entries
> >    s390/sclp: add extended-length sccb support for kvm guest
> >    s390/kvm: header sync for diag318
> >    s390: diagnose 318 info reset and migration support
> >
> >   hw/s390x/s390-virtio-ccw.c          |  45 +++++++++++++
> >   hw/s390x/sclp.c                     | 101 +++++++++++++++++++++-------
> >   include/hw/s390x/s390-virtio-ccw.h  |   1 +
> >   include/hw/s390x/sclp.h             |   4 ++
> >   linux-headers/asm-s390/kvm.h        |   5 ++
> >   smp.max_cpus                        |   0
>
> Probably a stray file? (Should be stripped from patch 2.)

Uhhh not sure how that got there :) Probably silly editor doing silly 
things. I'll make sure next round has that stripped.

> >   target/s390x/cpu.c                  |  19 ++++++
> >   target/s390x/cpu.h                  |   4 ++
> >   target/s390x/cpu_features.h         |   1 +
> >   target/s390x/cpu_features_def.inc.h |   4 ++
> >   target/s390x/cpu_models.c           |   1 +
> >   target/s390x/gen-features.c         |   2 +
> >   target/s390x/kvm-stub.c             |  10 +++
> >   target/s390x/kvm.c                  |  52 ++++++++++++++
> >   target/s390x/kvm_s390x.h            |   3 +
> >   15 files changed, 229 insertions(+), 23 deletions(-)
> >   create mode 100644 smp.max_cpus


--
--
Regards,
Collin

Stay safe and stay healthy