Re: [PATCH v3 0/9] pc-bios: s390x: Cleanup part 1

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [PATCH v3 0/9] pc-bios: s390x: Cleanup part 1
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
799f5f1 pc-bios: s390x: Make u32 ptr check explicit
64c8922 pc-bios: s390x: Use ebcdic2ascii table
3e12724 pc-bios: s390x: Move panic() into header and add infinite loop
49db366 pc-bios: s390x: Use PSW masks where possible and introduce 
PSW_MASK_SHORT_ADDR
1370a46 pc-bios: s390x: Rename and use PSW_MASK_ZMODE constant
9f1140a pc-bios: s390x: Get rid of magic offsets into the lowcore
dba1abc pc-bios: s390x: Move sleep and yield to helper.h
f694d50 pc-bios: s390x: Consolidate timing functions into time.h
ec7ac62 pc-bios: s390x: cio.c cleanup and compile fix

=== OUTPUT BEGIN ===
1/9 Checking commit ec7ac623cb81 (pc-bios: s390x: cio.c cleanup and compile fix)
2/9 Checking commit f694d5005ea2 (pc-bios: s390x: Consolidate timing functions 
into time.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#77: 
new file mode 100644

total: 0 errors, 1 warnings, 127 lines checked

Patch 2/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/9 Checking commit dba1abc5f5c8 (pc-bios: s390x: Move sleep and yield to 
helper.h)
4/9 Checking commit 9f1140afc2da (pc-bios: s390x: Get rid of magic offsets into 
the lowcore)
ERROR: spaces required around that ':' (ctx:VxV)
#30: FILE: pc-bios/s390-ccw/cio.h:127:
+            __u16 cssid:8;
                        ^

ERROR: spaces required around that ':' (ctx:VxV)
#31: FILE: pc-bios/s390-ccw/cio.h:128:
+            __u16 reserved:4;
                           ^

ERROR: spaces required around that ':' (ctx:VxV)
#32: FILE: pc-bios/s390-ccw/cio.h:129:
+            __u16 m:1;
                    ^

ERROR: spaces required around that ':' (ctx:VxV)
#33: FILE: pc-bios/s390-ccw/cio.h:130:
+            __u16 ssid:2;
                       ^

ERROR: spaces required around that ':' (ctx:VxV)
#34: FILE: pc-bios/s390-ccw/cio.h:131:
+            __u16 one:1;
                      ^

total: 5 errors, 0 warnings, 37 lines checked

Patch 4/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/9 Checking commit 1370a46cdd57 (pc-bios: s390x: Rename and use PSW_MASK_ZMODE 
constant)
6/9 Checking commit 49db366a3248 (pc-bios: s390x: Use PSW masks where possible 
and introduce PSW_MASK_SHORT_ADDR)
7/9 Checking commit 3e12724946c3 (pc-bios: s390x: Move panic() into header and 
add infinite loop)
8/9 Checking commit 64c89223f1f8 (pc-bios: s390x: Use ebcdic2ascii table)
9/9 Checking commit 799f5f138abb (pc-bios: s390x: Make u32 ptr check explicit)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden