Re: [PATCH v2 0/7] exec/cpu: Cleanups around "exec/hwaddr.h" (reserved to system-mode)

[Paolo Bonzini]

On 05/06/20 16:18, Cornelia Huck wrote:
> On Thu, 4 Jun 2020 20:11:38 +0200
> Paolo Bonzini <pbonzini@redhat.com> wrote:
> 
>> On 26/05/20 19:24, Philippe Mathieu-Daudé wrote:
>>> The 'hwaddr' type declared in "exec/hwaddr.h" is meant for
>>> system-mode emulation only.
>>> This series is a preparatory cleanup to allow later poisoning
>>> it in user-mode code.
>>>
>>> Missing review: patche 7
>>> - target/s390x: Restrict system-mode declarations
>>>
>>> Maybe PPC/S390X maintainers can take their patches and let
>>> the rest to Paolo, or he can take all the series. They are
>>> not dependents.
>>>
>>> Since v1:
>>> - Do not poison hwaddr type
>>> - Addressed Cornelia & David review comments
>>> - Added R-b/A-b
>>>
>>> $ git backport-diff -u v1
>>> Key:
>>> [----] : patches are identical
>>> [####] : number of functional differences between upstream/downstream patch
>>> [down] : patch is downstream-only
>>> The flags [FC] indicate (F)unctional and (C)ontextual differences, 
>>> respectively
>>>
>>> 001/7:[----] [--] 'sysemu/accel: Restrict machine methods to system-mode'
>>> 002/7:[----] [--] 'sysemu/tcg: Only declare tcg_allowed when TCG is 
>>> available'
>>> 003/7:[----] [--] 'sysemu/hvf: Only declare hvf_allowed when HVF is 
>>> available'
>>> 004/7:[----] [--] 'target/ppc: Restrict PPCVirtualHypervisorClass to 
>>> system-mode'
>>> 005/7:[----] [--] 'target/s390x: Only compile decode_basedisp() on 
>>> system-mode'
>>> 006/7:[0002] [FC] 'target/s390x/helper: Clean ifdef'ry'
>>> 007/7:[0005] [FC] 'target/s390x: Restrict system-mode declarations'
>>>
>>> Supersedes: <20200509130910.26335-1-f4bug@amsat.org>
>>>
>>> Philippe Mathieu-Daudé (7):
>>>   sysemu/accel: Restrict machine methods to system-mode
>>>   sysemu/tcg: Only declare tcg_allowed when TCG is available
>>>   sysemu/hvf: Only declare hvf_allowed when HVF is available
>>>   target/ppc: Restrict PPCVirtualHypervisorClass to system-mode
>>>   target/s390x: Only compile decode_basedisp() on system-mode
>>>   target/s390x/helper: Clean ifdef'ry
>>>   target/s390x: Restrict system-mode declarations
>>>
>>>  include/sysemu/accel.h          |  2 ++
>>>  include/sysemu/hvf.h            |  6 +++---
>>>  include/sysemu/tcg.h            |  2 +-
>>>  target/ppc/cpu.h                |  4 ++--
>>>  target/ppc/kvm_ppc.h            | 22 +++++++++++-----------
>>>  target/s390x/internal.h         | 16 +++++++++++-----
>>>  target/ppc/translate_init.inc.c |  4 ++++
>>>  target/s390x/helper.c           |  5 -----
>>>  8 files changed, 34 insertions(+), 27 deletions(-)
>>>   
>>
>> Queued all, thanks.
> 
> So, I guess I should unqueue patch 5-7 from s390-next again?

I can unqueue them too, no problem.

Paolo