[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 05/10] vfio-ccw: allow non-prefetch ORBs
From: |
Cornelia Huck |
Subject: |
[PULL 05/10] vfio-ccw: allow non-prefetch ORBs |
Date: |
Fri, 5 Jun 2020 17:37:51 +0200 |
From: Jared Rossi <jrossi@linux.ibm.com>
Remove the explicit prefetch check when using vfio-ccw devices.
This check does not trigger in practice as all Linux channel programs
are intended to use prefetch.
Newer Linux kernel versions do not require to force the PFCH flag with
vfio-ccw devices anymore.
Signed-off-by: Jared Rossi <jrossi@linux.ibm.com>
Reviewed-by: Eric Farman <farman@linux.ibm.com>
Message-Id: <20200512181535.18630-2-jrossi@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
hw/vfio/ccw.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c
index c8624943c177..63406184d226 100644
--- a/hw/vfio/ccw.c
+++ b/hw/vfio/ccw.c
@@ -74,16 +74,9 @@ static IOInstEnding vfio_ccw_handle_request(SubchDev *sch)
struct ccw_io_region *region = vcdev->io_region;
int ret;
- if (!(sch->orb.ctrl0 & ORB_CTRL0_MASK_PFCH)) {
- if (!(vcdev->force_orb_pfch)) {
- warn_once_pfch(vcdev, sch, "requires PFCH flag set");
- sch_gen_unit_exception(sch);
- css_inject_io_interrupt(sch);
- return IOINST_CC_EXPECTED;
- } else {
- sch->orb.ctrl0 |= ORB_CTRL0_MASK_PFCH;
- warn_once_pfch(vcdev, sch, "PFCH flag forced");
- }
+ if (!(sch->orb.ctrl0 & ORB_CTRL0_MASK_PFCH) && vcdev->force_orb_pfch) {
+ sch->orb.ctrl0 |= ORB_CTRL0_MASK_PFCH;
+ warn_once_pfch(vcdev, sch, "PFCH flag forced");
}
QEMU_BUILD_BUG_ON(sizeof(region->orb_area) != sizeof(ORB));
--
2.25.4
- [PULL 00/10] s390x update, Cornelia Huck, 2020/06/05
- [PULL 01/10] s390x/kvm: help valgrind in several places, Cornelia Huck, 2020/06/05
- [PULL 02/10] s390x: pv: Fix KVM_PV_PREP_RESET command wrapper name, Cornelia Huck, 2020/06/05
- [PULL 03/10] docs/s390x: document the virtual css, Cornelia Huck, 2020/06/05
- [PULL 05/10] vfio-ccw: allow non-prefetch ORBs,
Cornelia Huck <=
- [PULL 06/10] docs/s390x: document vfio-ccw, Cornelia Huck, 2020/06/05
- [PULL 04/10] docs/s390x: document 3270, Cornelia Huck, 2020/06/05
- [PULL 08/10] target/s390x: Only compile decode_basedisp() on system-mode, Cornelia Huck, 2020/06/05
- [PULL 07/10] MAINTAINERS: add Thomas as additional s390x maintainer, Cornelia Huck, 2020/06/05
- [PULL 09/10] target/s390x/helper: Clean ifdef'ry, Cornelia Huck, 2020/06/05
- [PULL 10/10] target/s390x: Restrict system-mode declarations, Cornelia Huck, 2020/06/05
- Re: [PULL 00/10] s390x update, Peter Maydell, 2020/06/05