[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 04/21] s390x/pv: Convert to ram_block_discard_disable()
From: |
Cornelia Huck |
Subject: |
Re: [PATCH v4 04/21] s390x/pv: Convert to ram_block_discard_disable() |
Date: |
Tue, 16 Jun 2020 13:17:32 +0200 |
On Wed, 10 Jun 2020 13:54:02 +0200
David Hildenbrand <david@redhat.com> wrote:
> Discarding RAM does not work as expected with protected VMs. Let's
> switch to ram_block_discard_disable() for now, as we want to get rid
> of qemu_balloon_inhibit(). Note that it will currently never fail, but
> might fail in the future with new technologies (e.g., virtio-mem).
>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Cornelia Huck <cohuck@redhat.com>
> Cc: Halil Pasic <pasic@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Janosch Frank <frankja@linux.ibm.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> hw/s390x/s390-virtio-ccw.c | 22 +++++++++++++---------
> 1 file changed, 13 insertions(+), 9 deletions(-)
Did not review in detail, but looks sane. Would like to see a sanity
check and ack from folks with access to a PV setup.
Acked-by: Cornelia Huck <cohuck@redhat.com>
- [PATCH v4 00/21] virtio-mem: Paravirtualized memory hot(un)plug, David Hildenbrand, 2020/06/10
- [PATCH v4 01/21] exec: Introduce ram_block_discard_(disable|require)(), David Hildenbrand, 2020/06/10
- [PATCH v4 03/21] accel/kvm: Convert to ram_block_discard_disable(), David Hildenbrand, 2020/06/10
- [PATCH v4 02/21] vfio: Convert to ram_block_discard_disable(), David Hildenbrand, 2020/06/10
- [PATCH v4 04/21] s390x/pv: Convert to ram_block_discard_disable(), David Hildenbrand, 2020/06/10
- Re: [PATCH v4 04/21] s390x/pv: Convert to ram_block_discard_disable(),
Cornelia Huck <=
- [PATCH v4 05/21] virtio-balloon: Rip out qemu_balloon_inhibit(), David Hildenbrand, 2020/06/10
- [PATCH v4 06/21] target/i386: sev: Use ram_block_discard_disable(), David Hildenbrand, 2020/06/10
- [PATCH v4 07/21] migration/rdma: Use ram_block_discard_disable(), David Hildenbrand, 2020/06/10
- [PATCH v4 08/21] migration/colo: Use ram_block_discard_disable(), David Hildenbrand, 2020/06/10
- [PATCH v4 09/21] linux-headers: update to contain virtio-mem, David Hildenbrand, 2020/06/10
- [PATCH v4 10/21] virtio-mem: Paravirtualized memory hot(un)plug, David Hildenbrand, 2020/06/10
- [PATCH v4 11/21] virtio-pci: Proxy for virtio-mem, David Hildenbrand, 2020/06/10
- [PATCH v4 12/21] MAINTAINERS: Add myself as virtio-mem maintainer, David Hildenbrand, 2020/06/10