Re: [PATCH v3 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

[no-reply]

Patchew URL: 
20200618222258.23287-1-walling@linux.ibm.com/">https://patchew.org/QEMU/20200618222258.23287-1-walling@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v3 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318
Type: series
Message-id: 20200618222258.23287-1-walling@linux.ibm.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200618222258.23287-1-walling@linux.ibm.com -> 
patchew/20200618222258.23287-1-walling@linux.ibm.com
Switched to a new branch 'test'
7c099e1 s390: guest support for diagnose 0x318
11cf174 s390/kvm: header sync for diag318
9858413 s390/sclp: add extended-length sccb support for kvm guest
a8e6274 s390/sclp: use cpu offset to locate cpu entries
b839587 s390/sclp: read sccb from mem based on sccb length
2d754fb s390/sclp: rework sclp boundary and length checks
a7dce9a s390/sclp: check sccb len before filling in data
ea700d4 s390/sclp: get machine once during read scp/cpu info

=== OUTPUT BEGIN ===
1/8 Checking commit ea700d4d8a47 (s390/sclp: get machine once during read 
scp/cpu info)
2/8 Checking commit a7dce9a1bf29 (s390/sclp: check sccb len before filling in 
data)
3/8 Checking commit 2d754fbb29f6 (s390/sclp: rework sclp boundary and length 
checks)
4/8 Checking commit b839587fc52a (s390/sclp: read sccb from mem based on sccb 
length)
5/8 Checking commit a8e6274f786b (s390/sclp: use cpu offset to locate cpu 
entries)
6/8 Checking commit 985841391b37 (s390/sclp: add extended-length sccb support 
for kvm guest)
WARNING: line over 80 characters
#115: FILE: target/s390x/cpu_features_def.inc.h:100:
+DEF_FEAT(EXTENDED_LENGTH_SCCB, "els", STFL, 140, "Extended-length SCCB 
facility")

total: 0 errors, 1 warnings, 80 lines checked

Patch 6/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/8 Checking commit 11cf174b3455 (s390/kvm: header sync for diag318)
8/8 Checking commit 7c099e11b2ba (s390: guest support for diagnose 0x318)
ERROR: line over 90 characters
#103: FILE: target/s390x/cpu_features_def.inc.h:125:
+/* Features exposed via SCLP SCCB Facilities byte 134 (bit numbers relative to 
byte-134) */

WARNING: line over 80 characters
#104: FILE: target/s390x/cpu_features_def.inc.h:126:
+DEF_FEAT(DIAG_318, "diag318", SCLP_FAC134, 0, "Control program name and 
version codes")

total: 1 errors, 1 warnings, 161 lines checked

Patch 8/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200618222258.23287-1-walling@linux.ibm.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200618222258.23287-1-walling@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com