[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 9/9] host trust limitation: Alter virtio default properties fo
From: |
David Gibson |
Subject: |
[PATCH v3 9/9] host trust limitation: Alter virtio default properties for protected guests |
Date: |
Fri, 19 Jun 2020 12:06:02 +1000 |
The default behaviour for virtio devices is not to use the platforms normal
DMA paths, but instead to use the fact that it's running in a hypervisor
to directly access guest memory. That doesn't work if the guest's memory
is protected from hypervisor access, such as with AMD's SEV or POWER's PEF.
So, if a host trust limitation mechanism is enabled, then apply the
iommu_platform=on option so it will go through normal DMA mechanisms.
Those will presumably have some way of marking memory as shared with the
hypervisor or hardware so that DMA will work.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/core/machine.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index a71792bc16..8dfc1bb3f8 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -28,6 +28,8 @@
#include "hw/mem/nvdimm.h"
#include "migration/vmstate.h"
#include "exec/host-trust-limitation.h"
+#include "hw/virtio/virtio.h"
+#include "hw/virtio/virtio-pci.h"
GlobalProperty hw_compat_5_0[] = {
{ "virtio-balloon-device", "page-poison", "false" },
@@ -1165,6 +1167,15 @@ void machine_run_board_init(MachineState *machine)
* areas.
*/
machine_set_mem_merge(OBJECT(machine), false, &error_abort);
+
+ /*
+ * Virtio devices can't count on directly accessing guest
+ * memory, so they need iommu_platform=on to use normal DMA
+ * mechanisms. That requires disabling legacy virtio support
+ * for virtio pci devices
+ */
+ object_register_sugar_prop(TYPE_VIRTIO_PCI, "disable-legacy", "on");
+ object_register_sugar_prop(TYPE_VIRTIO_DEVICE, "iommu_platform", "on");
}
machine_class->init(machine);
--
2.26.2
- [PATCH v3 0/9] Generalize memory encryption models, David Gibson, 2020/06/18
- [PATCH v3 3/9] host trust limitation: Move side effect out of machine_set_memory_encryption(), David Gibson, 2020/06/18
- [PATCH v3 1/9] host trust limitation: Introduce new host trust limitation interface, David Gibson, 2020/06/18
- [PATCH v3 2/9] host trust limitation: Handle memory encryption via interface, David Gibson, 2020/06/18
- [PATCH v3 4/9] host trust limitation: Rework the "memory-encryption" property, David Gibson, 2020/06/18
- [PATCH v3 8/9] spapr: PEF: block migration, David Gibson, 2020/06/18
- [PATCH v3 5/9] host trust limitation: Decouple kvm_memcrypt_*() helpers from KVM, David Gibson, 2020/06/18
- [PATCH v3 9/9] host trust limitation: Alter virtio default properties for protected guests,
David Gibson <=
- Re: [PATCH v3 9/9] host trust limitation: Alter virtio default properties for protected guests, Daniel P . Berrangé, 2020/06/19
- Re: [PATCH v3 9/9] host trust limitation: Alter virtio default properties for protected guests, Michael S. Tsirkin, 2020/06/19
- Re: [PATCH v3 9/9] host trust limitation: Alter virtio default properties for protected guests, Michael S. Tsirkin, 2020/06/19
- Re: [PATCH v3 9/9] host trust limitation: Alter virtio default properties for protected guests, Daniel P . Berrangé, 2020/06/19
- Re: [PATCH v3 9/9] host trust limitation: Alter virtio default properties for protected guests, Halil Pasic, 2020/06/19
- Re: [PATCH v3 9/9] host trust limitation: Alter virtio default properties for protected guests, Michael S. Tsirkin, 2020/06/24
- Re: [PATCH v3 9/9] host trust limitation: Alter virtio default properties for protected guests, David Gibson, 2020/06/25
- Re: [PATCH v3 9/9] host trust limitation: Alter virtio default properties for protected guests, David Gibson, 2020/06/25
- Re: [PATCH v3 9/9] host trust limitation: Alter virtio default properties for protected guests, David Gibson, 2020/06/19
- Re: [PATCH v3 9/9] host trust limitation: Alter virtio default properties for protected guests, Daniel P . Berrangé, 2020/06/19