Re: [PATCH v4 0/9] pc-bios: s390x: Cleanup part 1

[no-reply]

Patchew URL: 
20200622074235.32528-1-frankja@linux.ibm.com/">https://patchew.org/QEMU/20200622074235.32528-1-frankja@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v4 0/9] pc-bios: s390x: Cleanup part 1
Type: series
Message-id: 20200622074235.32528-1-frankja@linux.ibm.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
1e3716e pc-bios: s390x: Make u32 ptr check explicit
e1bae54 pc-bios: s390x: Use ebcdic2ascii table
7452b5e pc-bios: s390x: Move panic() into header and add infinite loop
6cdcbc6 pc-bios: s390x: Use PSW masks where possible and introduce 
PSW_MASK_SHORT_ADDR
6c39b23 pc-bios: s390x: Rename and use PSW_MASK_ZMODE constant
91817a3 pc-bios: s390x: Get rid of magic offsets into the lowcore
a6afbef pc-bios: s390x: Move sleep and yield to helper.h
aa61b56 pc-bios: s390x: Consolidate timing functions into time.h
103f588 pc-bios: s390x: cio.c cleanup and compile fix

=== OUTPUT BEGIN ===
1/9 Checking commit 103f588d1ee8 (pc-bios: s390x: cio.c cleanup and compile fix)
2/9 Checking commit aa61b56a0eea (pc-bios: s390x: Consolidate timing functions 
into time.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#93: 
new file mode 100644

total: 0 errors, 1 warnings, 142 lines checked

Patch 2/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/9 Checking commit a6afbefa38ab (pc-bios: s390x: Move sleep and yield to 
helper.h)
4/9 Checking commit 91817a34ed26 (pc-bios: s390x: Get rid of magic offsets into 
the lowcore)
ERROR: spaces required around that ':' (ctx:VxV)
#30: FILE: pc-bios/s390-ccw/cio.h:127:
+            __u16 cssid:8;
                        ^

ERROR: spaces required around that ':' (ctx:VxV)
#31: FILE: pc-bios/s390-ccw/cio.h:128:
+            __u16 reserved:4;
                           ^

ERROR: spaces required around that ':' (ctx:VxV)
#32: FILE: pc-bios/s390-ccw/cio.h:129:
+            __u16 m:1;
                    ^

ERROR: spaces required around that ':' (ctx:VxV)
#33: FILE: pc-bios/s390-ccw/cio.h:130:
+            __u16 ssid:2;
                       ^

ERROR: spaces required around that ':' (ctx:VxV)
#34: FILE: pc-bios/s390-ccw/cio.h:131:
+            __u16 one:1;
                      ^

total: 5 errors, 0 warnings, 37 lines checked

Patch 4/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/9 Checking commit 6c39b233de50 (pc-bios: s390x: Rename and use PSW_MASK_ZMODE 
constant)
6/9 Checking commit 6cdcbc6075b0 (pc-bios: s390x: Use PSW masks where possible 
and introduce PSW_MASK_SHORT_ADDR)
7/9 Checking commit 7452b5e64c9a (pc-bios: s390x: Move panic() into header and 
add infinite loop)
8/9 Checking commit e1bae544390e (pc-bios: s390x: Use ebcdic2ascii table)
9/9 Checking commit 1e3716e19075 (pc-bios: s390x: Make u32 ptr check explicit)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200622074235.32528-1-frankja@linux.ibm.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200622074235.32528-1-frankja@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com