[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 1/4] qga/qapi-schema: Document -1 for invalid PCI address fiel
|
From: |
Thomas Huth |
|
Subject: |
[PATCH v2 1/4] qga/qapi-schema: Document -1 for invalid PCI address fields |
|
Date: |
Wed, 22 Jul 2020 06:40:25 +0200 |
The "guest-get-fsinfo" could also be used for non-PCI devices in the
future. And the code in GuestPCIAddress() in qga/commands-win32.c seems
to be using "-1" for fields that it can not determine already. Thus
let's properly document "-1" as value for invalid PCI address fields.
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
qga/qapi-schema.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index 4be9aad48e..408a662ea5 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -846,7 +846,7 @@
##
# @GuestDiskAddress:
#
-# @pci-controller: controller's PCI address
+# @pci-controller: controller's PCI address (fields are set to -1 if invalid)
# @bus-type: bus type
# @bus: bus id
# @target: target id
--
2.18.1
- [PATCH v2 0/4] Allow guest-get-fsinfo also for non-PCI devices, Thomas Huth, 2020/07/22
- [PATCH v2 1/4] qga/qapi-schema: Document -1 for invalid PCI address fields,
Thomas Huth <=
- [PATCH v2 2/4] qga/commands-posix: Rework build_guest_fsinfo_for_real_device() function, Thomas Huth, 2020/07/22
- [PATCH v2 3/4] qga/commands-posix: Move the udev code from the pci to the generic function, Thomas Huth, 2020/07/22
- [PATCH v2 4/4] qga/commands-posix: Support fsinfo for non-PCI virtio devices, too, Thomas Huth, 2020/07/22
- Re: [PATCH v2 0/4] Allow guest-get-fsinfo also for non-PCI devices, Michael Roth, 2020/07/27